[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/15618
  
Hm.. @srowen @tdas and @mridulm . I just got rid of the changes in 
`ReceiverTracker.scala` here for now. It seems we can't make this `null` in 
`stop()` and create an instance in `start()` because this instance is being 
accessed after gracefully stopped. It seems the blocks should be able to be 
retrieved after stopped.

One way I am thinking is, initiate this `ReceivedBlockTracker` instance at 
`start()` in `ReceiverTracker` and add null checks in each method using 
`ReceivedBlockTracker` instance in `ReceiverTracker`. However, I am not sure 
whether it is worth adding such checks and that this is right or cleanest way 
as I am not familiar with this streaming part.

Could I please ask anyone who is familiar with this to make a followup if 
it is fine?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-06 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15618
  
**[Test build #68231 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68231/consoleFull)**
 for PR 15618 at commit 
[`a9a5f06`](https://github.com/apache/spark/commit/a9a5f061b8536c8b3173bb5701cb0de0bad99fcc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15618
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15618
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67928/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15618
  
**[Test build #67928 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67928/consoleFull)**
 for PR 15618 at commit 
[`1521572`](https://github.com/apache/spark/commit/15215722dfe2de0785d38cce5713f33fac5e4b03).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15618: [WIP][SPARK-14914][CORE] Fix Resource not closed after u...

2016-11-01 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15618
  
**[Test build #67928 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67928/consoleFull)**
 for PR 15618 at commit 
[`1521572`](https://github.com/apache/spark/commit/15215722dfe2de0785d38cce5713f33fac5e4b03).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org