[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15633 I took a look at this again tonight, in the context of consolidating this with Hive. I think doing it through callback is actually not ideal, as callbacks are harder to trace. In 2.2 we should make this an explicit action, rather than callbacks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15633 cc @cloud-fan @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15633 **[Test build #67671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67671/consoleFull)** for PR 15633 at commit [`8c4ae5e`](https://github.com/apache/spark/commit/8c4ae5eb7441fd5bc0b06276d5d02a2ebc6de4a0). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15633 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67671/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15633 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15633 **[Test build #67682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67682/consoleFull)** for PR 15633 at commit [`4d96725`](https://github.com/apache/spark/commit/4d967251ce01794f7cdab9f84b70fa5393d1d1f2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15633 **[Test build #67682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67682/consoleFull)** for PR 15633 at commit [`4d96725`](https://github.com/apache/spark/commit/4d967251ce01794f7cdab9f84b70fa5393d1d1f2). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15633 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15633 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67682/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15633 should we also fix `DataFrameWriter.saveAsTable`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15633 I think that one is ok since we have to scan the full table anyways. If it becomes a performance issue we can also add this optimization. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15633 **[Test build #3381 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3381/consoleFull)** for PR 15633 at commit [`4d96725`](https://github.com/apache/spark/commit/4d967251ce01794f7cdab9f84b70fa5393d1d1f2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15633 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15633 **[Test build #3381 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3381/consoleFull)** for PR 15633 at commit [`4d96725`](https://github.com/apache/spark/commit/4d967251ce01794f7cdab9f84b70fa5393d1d1f2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15633: [SPARK-18087] [SQL] Optimize insert to not require REPAI...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15633 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org