[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15834
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/15834
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68416/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15834
  
**[Test build #68416 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68416/consoleFull)**
 for PR 15834 at commit 
[`3536f6a`](https://github.com/apache/spark/commit/3536f6a44f15e2997a1061a6e7ec061f98c3ef9f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread yhuai
Github user yhuai commented on the issue:

https://github.com/apache/spark/pull/15834
  
Great. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread rdblue
Github user rdblue commented on the issue:

https://github.com/apache/spark/pull/15834
  
[SPARK-18387](https://issues.apache.org/jira/browse/SPARK-18387) tracks the 
other bugs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread yhuai
Github user yhuai commented on the issue:

https://github.com/apache/spark/pull/15834
  

![image](https://cloud.githubusercontent.com/assets/2072857/20150618/9d871bf2-a66b-11e6-8d21-1a9bb6eb27d7.png)

Since tests have already passed, I am merging this PR to 
master/branch-2.1/branch-2.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread yhuai
Github user yhuai commented on the issue:

https://github.com/apache/spark/pull/15834
  
Awesome! btw looks like your original changes in 
`ExpressionEvalHelper.scala` 
(https://github.com/apache/spark/pull/15816/files#diff-41747ec3f56901eb7bfb95d2a217e94d)
 uncovered issues with other expressions. Want to send a new pr to fix them as 
well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/15834
  
**[Test build #68416 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68416/consoleFull)**
 for PR 15834 at commit 
[`3536f6a`](https://github.com/apache/spark/commit/3536f6a44f15e2997a1061a6e7ec061f98c3ef9f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15834: [SPARK-18368] [SQL] Fix regexp replace when serialized

2016-11-09 Thread rdblue
Github user rdblue commented on the issue:

https://github.com/apache/spark/pull/15834
  
@yhuai, this replaces #15816. The ref,  3536f6a, has already passed 
tests on that PR so it should be safe to merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org