[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16481 Sure, will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16481 I'll update JIRA once the service is back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16481 LGTM, merging to master! It conflicts with branch-2.1, can you send a new PR? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71279/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #71279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71279/testReport)** for PR 16481 at commit [`111025f`](https://github.com/apache/spark/commit/111025f1d39b55db08896c35f46149dcacf9b3b3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #71279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71279/testReport)** for PR 16481 at commit [`111025f`](https://github.com/apache/spark/commit/111025f1d39b55db08896c35f46149dcacf9b3b3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71026/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #71026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71026/testReport)** for PR 16481 at commit [`7d3eefb`](https://github.com/apache/spark/commit/7d3eefbc30a14cd8457967170ea705b48c8d05e8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #71026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71026/testReport)** for PR 16481 at commit [`7d3eefb`](https://github.com/apache/spark/commit/7d3eefbc30a14cd8457967170ea705b48c8d05e8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70956/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #70956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70956/testReport)** for PR 16481 at commit [`2a8ce0b`](https://github.com/apache/spark/commit/2a8ce0be3e88c91ef3928fdd408c7075c2522c76). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #70956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70956/testReport)** for PR 16481 at commit [`2a8ce0b`](https://github.com/apache/spark/commit/2a8ce0be3e88c91ef3928fdd408c7075c2522c76). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16481 @cloud-fan I did a try in that direction, but I am afraid it might break the external data source that extends `CreatableRelationProvider`. Not sure what [it might be returned](https://github.com/gatorsmile/spark/blob/2a8ce0be3e88c91ef3928fdd408c7075c2522c76/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L432). Maybe more changes than the nullability. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16481 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70946/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #70946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70946/testReport)** for PR 16481 at commit [`5d38f09`](https://github.com/apache/spark/commit/5d38f09f47a767a342a0a8219c63efa2943b5d1f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16481 I think it's time to think about why `DataSource.write` should return `BaseRelation`. It seems that we only use it in `CreateDataSourceTableAsSelect`, to get the schema of the written data, only for nullability changes. Can we avoid doing this? Can we figure out the nullability changes more concisely? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16481 **[Test build #70946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70946/testReport)** for PR 16481 at commit [`5d38f09`](https://github.com/apache/spark/commit/5d38f09f47a767a342a0a8219c63efa2943b5d1f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter should...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16481 cc @ericl @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org