[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...

2017-01-16 Thread lshmouse
Github user lshmouse commented on the issue:

https://github.com/apache/spark/pull/16602
  
@srowen 
After checking the implements of timsort, it has been optimized for sorted 
array. 
Just ignore this PR. Thanks for your time.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...

2017-01-16 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/16602
  
Why is this faster than letting timsort figure out the array is sorted 
already? that's the key question. Because this adds an extra pass for any 
non-sorted data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #16602: [SPARK-19238][GRAPHX] Ignore sorting the edges if edges ...

2017-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/16602
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org