[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user acompa commented on the issue: https://github.com/apache/spark/pull/16618 I'm also curious about this @MLnick. Seems like there was a lot of movement earlier this year, but this PR has gotten stale. I can also contribute if @Kornel cannot for any reason. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user Kornel commented on the issue: https://github.com/apache/spark/pull/16618 @MLnick I'm wondering what's the status of this issue: seems closed, have you any plans on picking it up again? I might pick it up, but I'm not sure what's left: move from package mllib to ml and maybe a python API? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16618 @daniloascione any update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16618 @daniloascione are you able to update this? I'd like to target for `2.3`. But, can we do the following: 1. Port over ranking metrics (udfs) to `ml` with the `RankingEvaluator` as you've done, but _excluding_ MPR 2. Also don't make any logic changes for the metrics calculation Let's focus on porting things over and getting the API right. Then create follow up tickets for additional metrics (MPR and any others) as well as looking into correcting the logic and/or naming of the existing metrics. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16618 The basic direction looks right - I won't have time to review immediately. Spark 2.2 QA code freeze will happen shortly so this will wait until 2.3 dev cycle starts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16618: [SPARK-14409][ML][WIP] Add RankingEvaluator
Github user daniloascione commented on the issue: https://github.com/apache/spark/pull/16618 I rewrote the ranking metrics from the mllib package as UDFs (as suggested [here](https://issues.apache.org/jira/browse/SPARK-14409?focusedCommentId=15896933=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15896933)) with [minimum changes](https://github.com/apache/spark/pull/16618/commits/fa2155af8947347a2fc1e565cf05a19529022266) to the logic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
