[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Thanks for the help and review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16746 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16746 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16746 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16746 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77257/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16746 **[Test build #77257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77257/testReport)** for PR 16746 at commit [`91e12e1`](https://github.com/apache/spark/commit/91e12e1b30ea94b7f56471acfb98784758ddc0f3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16746 **[Test build #77257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77257/testReport)** for PR 16746 at commit [`91e12e1`](https://github.com/apache/spark/commit/91e12e1b30ea94b7f56471acfb98784758ddc0f3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16746 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Hi @dongjoon-hyun @gatorsmile, just circling back. Is it going to be impractical to check the PR against a VM rather than against a docker image? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 @dongjoon-hyun Yup, I was using a real instance for testing. The best way to test without a real instance is probably going to be using the Teradata Express vm: http://downloads.teradata.com/download/database/teradata-express-for-vmware-player. You can also build an instance using an AMI but it's fairly expensive for an AMI so I'd recommend the express vm instead. Unfortunately there's currently not a dockerized version available. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16746 BTW, @klinvill . Do you use a real instance? Could you advice how the other persons like me can verify your PR on Teradata? Maybe, can we check Teradata Express or AWS Marketplace? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 I just tested it manually with a Teradata instance I have running. I didn't test it too extensively other than making sure that a write to a teradata table using a string datatype was working correctly for smaller strings (<255 characters). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16746 I do not have a solution to plug in VM into our test framework. How are you doing the test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user klinvill commented on the issue: https://github.com/apache/spark/pull/16746 Unfortunately I don't think there's a docker image for Teradata available yet. They do have the VM version and an AMI. Would either of those be sufficient? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16746 Are we able to find a docker image for Teradata Express? For example, we did it for [Postgres](https://github.com/eBay/Spark/blob/master/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala). Otherwise, it is hard for us to do the test for verification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16746: [SPARK-15648][SQL] Add teradataDialect for JDBC connecti...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16746 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
