[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16757 It had a merge conflict, so I opened: https://github.com/apache/spark/pull/16843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16757 This was merged to master only right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72526/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72526/testReport)** for PR 16757 at commit [`29c4696`](https://github.com/apache/spark/commit/29c469643bdab299cafd4fbbd657d34601c0e690). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16757 Merging this to master/2.1/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72521/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72521/testReport)** for PR 16757 at commit [`29c4696`](https://github.com/apache/spark/commit/29c469643bdab299cafd4fbbd657d34601c0e690). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72526/testReport)** for PR 16757 at commit [`29c4696`](https://github.com/apache/spark/commit/29c469643bdab299cafd4fbbd657d34601c0e690). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72520/testReport)** for PR 16757 at commit [`23743e1`](https://github.com/apache/spark/commit/23743e1e52f7bb764eb5743abdd773b73166a7d7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16757 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72520/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72521/testReport)** for PR 16757 at commit [`29c4696`](https://github.com/apache/spark/commit/29c469643bdab299cafd4fbbd657d34601c0e690). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16757 LGTM except one minor comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72520/testReport)** for PR 16757 at commit [`23743e1`](https://github.com/apache/spark/commit/23743e1e52f7bb764eb5743abdd773b73166a7d7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72374/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72374/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72374/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16757 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72372/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72372/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72372/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16757 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72323/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72323/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72323/testReport)** for PR 16757 at commit [`acbb9e0`](https://github.com/apache/spark/commit/acbb9e03a4cb36525920985e96983c3abd0f7326). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16757 The new `RemoveRedundantAliases` rule looks convoluted, is it possible to implement an O(1) complex `isParent` method on `TreeNode`? that could make the logic much simpler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16757 I do not explicitly implement 'traversing the parent tree'. I have opened up a few methods in `TreeNode` and `QueryPlan` so you can write your own (recursive) tree traversal. In this case this allows me to setup the blacklist before transforming the child nodes, to get determine which child attributes have changed, and to apply these changes to the parent node. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16757 > This PR fixes these problems by using a blacklist for attributes that are not to be moved, and by making sure that attribute remapping is only done for the parent tree, and not for unrelated parts of the query plan. Where do you implement "traversing the parent tree"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72248/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72248/testReport)** for PR 16757 at commit [`81f2fa5`](https://github.com/apache/spark/commit/81f2fa5df7b56f96db396cdb7fd0a9b1d5e75c89). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16757: [SPARK-18609][SPARK-18841][SQL] Fix redundant Alias remo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16757 **[Test build #72248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72248/testReport)** for PR 16757 at commit [`81f2fa5`](https://github.com/apache/spark/commit/81f2fa5df7b56f96db396cdb7fd0a9b1d5e75c89). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
