[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16860 LGTM Merging with master Thanks @sueann ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16860 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16860 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72607/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16860 **[Test build #72607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72607/testReport)** for PR 16860 at commit [`ce8abb3`](https://github.com/apache/spark/commit/ce8abb308c0b555754d332712d922a7aa9a8b220). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16860 Try running dev/mima locally. I bet you'll have to add stuff to the MiMaExcludes.scala file b/c of false positives. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16860 Oh, the class is private already, right on. That seems OK then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16860 @srowen This actually isn't a breaking change. This is making protected methods private within classes which cannot be extended outside of Spark. The classes are not final, but they only provide private constructors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16860 **[Test build #72607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72607/testReport)** for PR 16860 at commit [`ce8abb3`](https://github.com/apache/spark/commit/ce8abb308c0b555754d332712d922a7aa9a8b220). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16860: [SPARK-18613][ML] make spark.mllib LDA dependencies in s...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16860 I get it, but making something less visible after it's released is also a breaking change. Without a good reason for that we shouldn't make changes like this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
