[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74195/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74195/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74195/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74186/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74186/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74181/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74181/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74181/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74152/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74152/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74152/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74135/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74135/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17075 **[Test build #74135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74135/testReport)** for PR 17075 at commit [`fc0f2d1`](https://github.com/apache/spark/commit/fc0f2d11f60dc1eade4c32d5a56292766061886e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 sorry forgot the trigger the test... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user wojtek-szymanski commented on the issue: https://github.com/apache/spark/pull/17075 @cloud-fan could you please give the green light to tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 LGTM, pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 how about we add a new method `toPrecision` that returns `Option[Decimal]`? Most of the time we should call `toPrecision`, but for some performance critical path we should call `changePrecission` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user wojtek-szymanski commented on the issue: https://github.com/apache/spark/pull/17075 I have just started refactoring of `changePrecission` in order to make it immutable. My idea was to change the signature from: `def changePrecision(precision: Int, scale: Int, mode: Int): Boolean` into `def changePrecision(precision: Int, scale: Int, mode: Int): Option[Decimal]` Here are my first thoughts: - `org.apache.spark.sql.types.Decimal` is mutable by definition, so making one method immutable makes its contract very inconsistent - I am afraid of performance degradation in micro-benchmarks since in some use cases, an instance needs to be created twice - `changePrecission` is called 10 times in Scala, 10 times in **code gen** functions and 3 times in Java **unsafe** writers (`UnsafeArrayWriter`, `UnsafeRowWriter`) I would be grateful if you could confirm if it's the right way to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user wojtek-szymanski commented on the issue: https://github.com/apache/spark/pull/17075 Good idea @cloud-fan. I will look for usages of `changePrecision` then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17075 I think we should fix `changePrecison` to return a new instance instead of updating itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17075 I dont' know the code well enough to really evaluate this, but, I see that `.clone()` is called in a similar context in `decimalExpressions`. There are also similar usages of `changePrecision` in `UnsafeArrayWriter` and `UnsafeRowWriter`; I wonder if they are affected too? CC maybe @cloud-fan or @yjshen ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17075: [SPARK-19727][SQL] Fix for round function that modifies ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17075 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
