[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17358 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #3605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3605/testReport)** for PR 17358 at commit [`1338a75`](https://github.com/apache/spark/commit/1338a759a8d0e14370dddcf806ca03cb5e31ec3c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #3605 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3605/testReport)** for PR 17358 at commit [`1338a75`](https://github.com/apache/spark/commit/1338a759a8d0e14370dddcf806ca03cb5e31ec3c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #75035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75035/testReport)** for PR 17358 at commit [`1338a75`](https://github.com/apache/spark/commit/1338a759a8d0e14370dddcf806ca03cb5e31ec3c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #75035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75035/testReport)** for PR 17358 at commit [`1338a75`](https://github.com/apache/spark/commit/1338a759a8d0e14370dddcf806ca03cb5e31ec3c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75028/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 Actually thank you for your comments, I missed one file in swarm of errors from generated files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17358 Sorry for making this PR dragged. I am fine. Let me cope with it separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #75028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75028/testReport)** for PR 17358 at commit [`1338a75`](https://github.com/apache/spark/commit/1338a759a8d0e14370dddcf806ca03cb5e31ec3c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 @HyukjinKwon, Fixing those errors require fixing unidoc plugin's java code generation. IMO, that has a broader scope. What do you think ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17358 If my suggestion is the reason to hold off this PR currently and you are not sure of it, I am fine. I can double-check and deal with this in a separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74883/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #74883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74883/testReport)** for PR 17358 at commit [`ab3fb76`](https://github.com/apache/spark/commit/ab3fb7636fbc0e53d15d8c7867cce7e0a0e61a28). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17358 Yea, It generates java codes for Java API. I suggested to fix these together because they look similar instances and I didn't want to open another minor PR for this (BTW, [FlatMapGroupsWithStateFunction.java](https://github.com/apache/spark/blob/master/sql/core/src/main/java/org/apache/spark/api/java/function/FlatMapGroupsWithStateFunction.java) seems not a generated code). If you think this should be separately handled in another PR, then I am happy to do so. If you meant it is not an issue, I tried both ``` rm -fr target ./build/sbt clean ./build/sbt unidoc ``` and `cd docs && jekyll build` I see ``` [error] (spark/javaunidoc:doc) javadoc returned nonzero exit code ``` and ``` jekyll 3.3.1 | Error: Unidoc generation failed ``` due to those four errors and I don't see `_site` and the Java API documentation after `jekyll build` as written in [docs#generating-the-documentation-html](https://github.com/apache/spark/tree/master/docs#generating-the-documentation-html). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #74883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74883/testReport)** for PR 17358 at commit [`ab3fb76`](https://github.com/apache/spark/commit/ab3fb7636fbc0e53d15d8c7867cce7e0a0e61a28). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/17358 Hi @HyukjinKwon !, Thank for looking at this. I did one pass through all those errors, they seem to be inside the generated code. Please notice `/target` in the path. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17358 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74863/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17358
Hi @ScrapCodes, I just happened to look at this PR and ran `jeykill build`
against this PR.
It seems there are few more instances to make javadoc8 working as below:
```
[error]
.../spark/mllib/target/java/org/apache/spark/ml/fpm/FPGrowthParams.java:17:
error: bad use of '>'
[error]* Number of partitions (>=1) used by parallel FP-growth. By
default the param is not set, and
[error]^
[error]
.../spark/sql/core/src/main/java/org/apache/spark/api/java/function/FlatMapGroupsWithStateFunction.java:30:
error: reference not found
[error] * {@link
org.apache.spark.sql.KeyValueGroupedDataset#flatMapGroupsWithState(
[error] ^
[error]
.../spark/core/target/java/org/apache/spark/TaskContextImpl.java:10: error:
reference not found
[error] * {@link TaskMetrics} {@link MetricsSystem} objects are not
thread safe.
[error] ^
[error]
.../spark/core/target/java/org/apache/spark/TaskContextImpl.java:10: error:
reference not found
[error] * {@link TaskMetrics} {@link MetricsSystem} objects are not
thread safe.
[error]
```
Should we maybe sweep these together if I found them correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17358: [SPARK-20027][DOCS] Compilation fix in java docs.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17358 **[Test build #74863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74863/testReport)** for PR 17358 at commit [`4351840`](https://github.com/apache/spark/commit/4351840537049e2a252ff8145c2c4ef1388b5049). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
