[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @squito Thanks a lot for merging :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user squito commented on the issue: https://github.com/apache/spark/pull/17634 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #3767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3767/testReport)** for PR 17634 at commit [`cb80dbd`](https://github.com/apache/spark/commit/cb80dbd7b66cbd968b6bb40aa4143b42bb181ccf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #3767 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3767/testReport)** for PR 17634 at commit [`cb80dbd`](https://github.com/apache/spark/commit/cb80dbd7b66cbd968b6bb40aa4143b42bb181ccf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user squito commented on the issue: https://github.com/apache/spark/pull/17634 lgtm. sorry for such a late review. Since its been a while I'll trigger tests again just to be safe before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 Yes. it doesn't fail for sure. I just think it's fairly straightforward that partitioner should be compatible with num of child RDD's partitions. I find no reason the num of partitions are not equal in those test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17634 Don't think we could fail on the original test case for any reason, otherwise the legacy user code could fail unexpectedly, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @jiangxb1987 Thank you so much taking time looking into this. Yes, it is not failing in existing code. But I think it's quite straightforward that partitioner should be compatible with num of child RDD's partitions, right? In #17533, I have to query the `MapStatus` based on the correctness of partitioner(i.e. num of partitions). That's why I proposed this. Thanks again taking time reviewing this :) ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17634 The test cases are not falling on master branch, are there some good reason to change them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @kayousterhout @mridulm Does this pr make sense? Could you please take a look this when you have time :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 @squito @srowen Could you help comment on this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75788/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #75788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75788/testReport)** for PR 17634 at commit [`cb80dbd`](https://github.com/apache/spark/commit/cb80dbd7b66cbd968b6bb40aa4143b42bb181ccf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75787/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #75787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75787/testReport)** for PR 17634 at commit [`e9d8297`](https://github.com/apache/spark/commit/e9d82977b1bee6aa0573bd745985e97a81b8e514). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #75788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75788/testReport)** for PR 17634 at commit [`cb80dbd`](https://github.com/apache/spark/commit/cb80dbd7b66cbd968b6bb40aa4143b42bb181ccf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17634 **[Test build #75787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75787/testReport)** for PR 17634 at commit [`e9d8297`](https://github.com/apache/spark/commit/e9d82977b1bee6aa0573bd745985e97a81b8e514). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17634: [SPARK-20333] HashPartitioner should be compatible with ...
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/17634 I found this when doing https://github.com/apache/spark/pull/17533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
