[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17776 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76196/testReport)** for PR 17776 at commit [`04e4e9d`](https://github.com/apache/spark/commit/04e4e9daf89576ca5e2163f760c054e82098). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76196/testReport)** for PR 17776 at commit [`04e4e9d`](https://github.com/apache/spark/commit/04e4e9daf89576ca5e2163f760c054e82098). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76196/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76200/testReport)** for PR 17776 at commit [`e2d1d4f`](https://github.com/apache/spark/commit/e2d1d4f420a5844b968dd25bcf4565792f318fea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76200 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76200/testReport)** for PR 17776 at commit [`e2d1d4f`](https://github.com/apache/spark/commit/e2d1d4f420a5844b968dd25bcf4565792f318fea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76200/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76206/testReport)** for PR 17776 at commit [`627cdd7`](https://github.com/apache/spark/commit/627cdd7c382aac13704998dd3b5971ec0a684d19). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76206/testReport)** for PR 17776 at commit [`627cdd7`](https://github.com/apache/spark/commit/627cdd7c382aac13704998dd3b5971ec0a684d19). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76206/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76207/testReport)** for PR 17776 at commit [`24f37f1`](https://github.com/apache/spark/commit/24f37f1df3350b3e9977f617c07febeff16cba6c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17776 @gatorsmile can you say more about what is the bug? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76207/testReport)** for PR 17776 at commit [`24f37f1`](https://github.com/apache/spark/commit/24f37f1df3350b3e9977f617c07febeff16cba6c). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class ComplexTypesSuite extends PlanTest` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76207/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17776 When users do not provide alias name in the SELECT query, we call `toPrettySQL` to generate the alias name. For example, the string `get_json_object(jstring, '$.f1')` will be the alias name for the function call in the statement ```SQL SELECT key, get_json_object(jstring, '$.f1') FROM tempView ``` Above is not an issue for the SELECT query statements. However, for CTAS, we hit the issue due to a bug in Hive metastore. Hive metastore does not like the column names containing commas and returned a confusing error message, like: ``` 17/04/26 23:12:56 ERROR [hive.log(397) -- main]: error in initSerDe: org.apache.hadoop.hive.serde2.SerDeException org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe: columns has 2 elements while columns.types has 1 elements! org.apache.hadoop.hive.serde2.SerDeException: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe: columns has 2 elements while columns.types has 1 elements! ``` Thus, this PR is to remove the comma from the alias names so that Spark SQL users can do CTAS for the function call containing commas but without user-given alias names. BTW, also add the description into the PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76216/testReport)** for PR 17776 at commit [`bcb8cf7`](https://github.com/apache/spark/commit/bcb8cf74bee92cb04c97f1d64254123df2fb393b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17776 @cloud-fan @sameeragarwal @hvanhovell @ueshin Should we just fix the issue in CTAS? Even if users provide commas in the alias names, we just simply remove it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17776 **[Test build #76216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76216/testReport)** for PR 17776 at commit [`bcb8cf7`](https://github.com/apache/spark/commit/bcb8cf74bee92cb04c97f1d64254123df2fb393b). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76216/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17776: [SPARK-20476] [SQL] Exclude Comma From Our Auto-generate...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17776 Close this to prefer another PR https://github.com/apache/spark/pull/17776 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
