[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17836 to be safe, can we create a new PR for 2.2? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 It's cherry-pickable into branch-2.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Hi, @cloud-fan . Apache Spark 2.2 seems to be passed now. Do you think it is possible to backport this into `branch-2.2` for 2.2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Thank you for review and merging again, @kiszk and @cloud-fan . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17836 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17836 Thanks, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76438/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76438/testReport)** for PR 17836 at commit [`2b58c9f`](https://github.com/apache/spark/commit/2b58c9f224b5cffcad7b5b9d798c83cbc7bd37af). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76438/testReport)** for PR 17836 at commit [`2b58c9f`](https://github.com/apache/spark/commit/2b58c9f224b5cffcad7b5b9d798c83cbc7bd37af). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Sure, @kiszk . I'll update the other test suite to improve coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76411/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76411/testReport)** for PR 17836 at commit [`6cec5da`](https://github.com/apache/spark/commit/6cec5da1d8bbac3c4a4398cd847defc48ab12451). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17836 Good catch. Is is better to apply these changes to other types (e.g. null, boolean, byte, short, int, and long)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 I updated the test cases to include `appendFloat/appendFloats/appendDouble/appendDoubles`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76411 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76411/testReport)** for PR 17836 at commit [`6cec5da`](https://github.com/apache/spark/commit/6cec5da1d8bbac3c4a4398cd847defc48ab12451). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Thank you, @michal-databricks and @viirya . It was my mistake. I thought I did all. :( I'll add that correctly, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user michal-databricks commented on the issue:
https://github.com/apache/spark/pull/17836
Not sure if intentional, but the added test ("Float APIs") does not cover
the new function (is uses put API mostly). Actually as far as I can see
the "appends" APIs are not used at all in the code. The singular versions
are also not covered by the tests but is used by toBatch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Thank you for review, @hvanhovell and @cloud-fan . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17836 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17836 cc @michal-databricks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76404/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76404/testReport)** for PR 17836 at commit [`d979d0f`](https://github.com/apache/spark/commit/d979d0f482758d2d763fc88f456388ba9caf9274). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17836 Thank you for review, @kiszk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17836 LGTM cc: @sameeragarwal @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17836: [SPARK-20566][SQL] ColumnVector should support `appendFl...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17836 **[Test build #76404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76404/testReport)** for PR 17836 at commit [`d979d0f`](https://github.com/apache/spark/commit/d979d0f482758d2d763fc88f456388ba9caf9274). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
