[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/18084
  
thanks, merging to master!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78049/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #78049 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78049/testReport)**
 for PR 18084 at commit 
[`9ddf23a`](https://github.com/apache/spark/commit/9ddf23af3ee5853c5d1b53a05afc38f38509a8c2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/18084
  
LGTM, pending test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-14 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #78049 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78049/testReport)**
 for PR 18084 at commit 
[`9ddf23a`](https://github.com/apache/spark/commit/9ddf23af3ee5853c5d1b53a05afc38f38509a8c2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78023/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #78023 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78023/testReport)**
 for PR 18084 at commit 
[`0887eab`](https://github.com/apache/spark/commit/0887eab874dac34b99c6dec58c979b3f8ee3feb7).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `public class KVStoreSerializer `
  * `public abstract class KVStoreView implements Iterable `
  * `public class KVTypeInfo `
  * `public class LevelDB implements KVStore `
  * `  public static class TypeAliases `
  * `class LevelDBIterator implements KVStoreIterator `
  * `class LevelDBTypeInfo `
  * `  class Index `
  * `public class UnsupportedStoreVersionException extends IOException `
  * `  logError(s\"Not measuring processing time for listener class 
$className because a \" +`
  * `class FilteredObjectInputStream extends ObjectInputStream `
  * `String.format(\"Unexpected class in stream: %s\", 
desc.getName()));`
  * `class HasMinSupport(Params):`
  * `class HasNumPartitions(Params):`
  * `class HasMinConfidence(Params):`
  * `case class UnresolvedRelation(`
  * `case class DayOfWeek(child: Expression) extends UnaryExpression with 
ImplicitCastInputTypes `
  * `case class Uuid() extends LeafExpression `
  * `case class StringReplace(srcExpr: Expression, searchExpr: Expression, 
replaceExpr: Expression)`
  * `case class Chr(child: Expression) extends UnaryExpression with 
ImplicitCastInputTypes `
  * `trait Command extends LogicalPlan `
  * `case class UnresolvedHint(name: String, parameters: Seq[Any], child: 
LogicalPlan)`
  * `case class ResolvedHint(child: LogicalPlan, hints: HintInfo = 
HintInfo())`
  * `case class HintInfo(broadcast: Boolean = false) `
  * `public final class ParquetDictionary implements Dictionary `
  * `case class ExecutedCommandExec(cmd: RunnableCommand, children: 
Seq[SparkPlan]) extends SparkPlan `
  * `class RateSourceProvider extends StreamSourceProvider with 
DataSourceRegister `
  * `class RateStreamSource(`
  * `case class StateStoreId(`
  * `class UnsafeRowPair(var key: UnsafeRow = null, var value: UnsafeRow = 
null) `
  * `trait StateStoreWriter extends StatefulOperator `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #78023 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78023/testReport)**
 for PR 18084 at commit 
[`0887eab`](https://github.com/apache/spark/commit/0887eab874dac34b99c6dec58c979b3f8ee3feb7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/18084
  
Also please rebase the latest master :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/18084
  
the fix LGTM, it would be better to add some comments to explain it clearly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-13 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/18084
  
I think your point is, in case a LaunchDriver message and a KillDriver 
message are send out simultaneously, there is a race condition that which 
message arrives to worker earlier is not determined. If the KillDriver message 
arrives later, then we finally get a finished driver instead of a running 
driver.
So, I'm not against the idea that we should rise the driver id on relaunch 
now, because it is kind of a new epoch that help us bypass the nested race 
condition issue. But please be sure to add comment to illustrate the condition 
in detail and add test cases to cover this.
Also cc @cloud-fan FYI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-12 Thread liyichao
Github user liyichao commented on the issue:

https://github.com/apache/spark/pull/18084
  
OK, another scenario:

* driver with driverId1 started on worker1
* worker1 lost
* master add driverId1 to waitingDrivers
* worker1 reconnects and sends DriverStateChanged(driverId1), but the 
message delayed in the network, **and remove driverId1 from local state**
* master starts driverId1 on worker1.
* master receives the message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-12 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/18084
  
We should also check in Worker that we don't launch duplicate drivers, I 
think the logic should be added in handling `LaunchDriver` message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-06-12 Thread liyichao
Github user liyichao commented on the issue:

https://github.com/apache/spark/pull/18084
  
Hi, add a workerId may not work. For example, this scenario:

* driver with driverId1 started on worker1
* worker1 lost
* master add driverId1 to waitingDrivers
* worker1 reconnects and sends DriverStateChanged(driverId1), but the 
message delayed in the network.
* master starts driverId1 on worker1.
* master receives the message.

Now, what master should do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-31 Thread liyichao
Github user liyichao commented on the issue:

https://github.com/apache/spark/pull/18084
  
ping @jiangxb1987 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77423/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77423 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77423/testReport)**
 for PR 18084 at commit 
[`da0f977`](https://github.com/apache/spark/commit/da0f977f2846d7051102a32521a1704dca74ed12).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread liyichao
Github user liyichao commented on the issue:

https://github.com/apache/spark/pull/18084
  
Hi, I've thought more thoroughly about this.

The main state involved here is Master.workers, Master.idToWorker, and 
WorkerInfo.drivers. Say `driverId1` runs on Worker A. Assume A is network 
partitioned, master calls removeWorker which set the worker's state to DEAD, 
and remove the worker from persistenceEngine, but does not remove it from 
Master.workers. Then launch the driver on Worker B. 

When A reconnects, it will reregister to master, then master will remove 
the old WorkerInfo (whose `drivers` field is not empty), and add a new 
WorkerInfo (say `wf_A`), whose drivers are empty. After registered, the worker 
then re-sync state with master by sending `WorkerLatestState` with a 
`driverId1`, the master does not find it in `wf_A.drivers`, so it asks worker A 
to kill it. After killed the driver, worker A sends 
`DriverStateChanged(driverId1, DriverState.KILLED)`, the master then mistakenly 
removes `driverId1`, which now runs on worker B.

How to recognize the `DriverStateChanged` come from worker A, not worker B? 
Maybe we can add a field `workerId` to `DriverStateChanged`, but is it possible 
the second run of `driverId1` is on worker A? consider the following scenario:

1. worker A network partitioned
2. master put `driverId1` to waitingDrivers
3. worker A reconnects and register
4. master launch `driverId1` on worker A
5. worker A's `WorkerLatestState(_,_,Seq(driverId1))` arrives at master

Now, how does worker A handle the `LaunchDriver(driverId1)` when it has 
already running a driver with `driverId1`? how does the master process 
`WorkerLatestState`? With the above message order, master will send 
`KillDriver` to worker A, then worker will kill `driverId1`, which is the 
relaunched one, then send `DriverStateChanged` to master, master will relaunch 
it...

After all this, I think it better to relaunch the driver with a new id to 
make it simple. As to the cost, `removeDriver` will be called anyway, if not 
here, it will be called when `DriverStateChanged` come. `persistenceEngine` 
have to be called because the persistent state `driver.id` changed. So the cost 
is justified. And `relaunchDriver` is called when worker down or master down, 
it seems rarely because framework code is more stable than application code, so 
software bugs are less likely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread liyichao
Github user liyichao commented on the issue:

https://github.com/apache/spark/pull/18084
  
Thanks for the reply. I have add some more tests to verify the state of 
master and worker after relaunching.

I will try think about if there are ways to reuse the old driver struct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-26 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77423 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77423/testReport)**
 for PR 18084 at commit 
[`da0f977`](https://github.com/apache/spark/commit/da0f977f2846d7051102a32521a1704dca74ed12).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-25 Thread jiangxb1987
Github user jiangxb1987 commented on the issue:

https://github.com/apache/spark/pull/18084
  
Maybe some more actions should be done in `relaunchDriver()` such as have 
`driver.worker` removes the dependency of the relaunched driver, but it will be 
sort of wasting resources to remove and later create a new driver, we should 
always prevent doing such things.

Now, to help us step forward, would you like to spend some time to create a 
valid regression test case? That will help a lot when we are discussing further 
about the proper bug-fix proposal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77353/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77353 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77353/testReport)**
 for PR 18084 at commit 
[`6ab9a0f`](https://github.com/apache/spark/commit/6ab9a0f5a62e4ec3c9757f748ff5e278d4741d25).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `class MockWorker(master: RpcEndpointRef, conf: SparkConf = new 
SparkConf) extends RpcEndpoint `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-25 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77353 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77353/testReport)**
 for PR 18084 at commit 
[`6ab9a0f`](https://github.com/apache/spark/commit/6ab9a0f5a62e4ec3c9757f748ff5e278d4741d25).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77312/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77312 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77312/testReport)**
 for PR 18084 at commit 
[`9ea2061`](https://github.com/apache/spark/commit/9ea20611f28e845e9c74626aee3e191656fa01bb).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18084
  
**[Test build #77312 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77312/testReport)**
 for PR 18084 at commit 
[`9ea2061`](https://github.com/apache/spark/commit/9ea20611f28e845e9c74626aee3e191656fa01bb).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/18084
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18084: [SPARK-19900][core]Remove driver when relaunching.

2017-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18084
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org