[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-30 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/18124
  
I don't think we'd change this then if it's kind of complicating the code 
and for a non-standard usage anyway. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-30 Thread nonsleepr
Github user nonsleepr commented on the issue:

https://github.com/apache/spark/pull/18124
  
@jerryshao You're right, it won't be empty if I run the app using 
spark-submit. The whole reason I encountered this bug is that in my project I'm 
running Spark job remotely (via YARN's REST API) from the node which doesn't 
have Spark distro.
My motivation for running it is another story but in short: I don't want to 
upload my keytab to HDFS to run spark-submit and instead I request delegation 
tokens for the services my job uses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-26 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/spark/pull/18124
  
I'm not sure how this could be happened, "SPARK_YARN_STAGING_DIR" is a 
Spark internal environment variable which should be empty, unless you 
deliberately unset it.

In the JIRA you mentioned you directly running `ApplicationMaster`, so that 
you met this issue, I'm not sure why you need to directly call 
`ApplicationMaster`?

BTW seems you submitted a PR against branch 2.1, why not against master 
branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-26 Thread nonsleepr
Github user nonsleepr commented on the issue:

https://github.com/apache/spark/pull/18124
  
@srowen Because `Path` will perform multiple checks. E.g. check for `null` 
or empty string and then URI syntax exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18124
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...

2017-05-26 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/18124
  
Why? instead of check the value of the env variable directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org