[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78912/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78912/testReport)** for PR 18357 at commit [`a2f30f0`](https://github.com/apache/spark/commit/a2f30f07e7e72dfacb801032bfc71bb9fda1b650). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78912/testReport)** for PR 18357 at commit [`a2f30f0`](https://github.com/apache/spark/commit/a2f30f07e7e72dfacb801032bfc71bb9fda1b650). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18357 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78838/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78838/testReport)** for PR 18357 at commit [`a2f30f0`](https://github.com/apache/spark/commit/a2f30f07e7e72dfacb801032bfc71bb9fda1b650). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78838/testReport)** for PR 18357 at commit [`a2f30f0`](https://github.com/apache/spark/commit/a2f30f07e7e72dfacb801032bfc71bb9fda1b650). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/18357 can we change SparkUncaughtExceptionHandler to class and create instance in each daemons main() with the constructor flag whether to kill the process for Exceptions or not? Something like below, For Executor : -- Thread.setDefaultUncaughtExceptionHandler(new SparkUncaughtExceptionHandler(true)) // Here true denotes to kill the process for Exceptions For Other Daemons: -- Thread.setDefaultUncaughtExceptionHandler(new SparkUncaughtExceptionHandler(false)) // false denotes not to kill the process for Exceptions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18357 @devaraj-kavali SparkUncaughtExceptionHandler is a singleton so you cannot get the configuration from SparkConf. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/18357 @zsxwing Thanks for looking into this, I see SparkUncaughtExceptionHandler exits the process for all the exceptions/errors. Can we modify SparkUncaughtExceptionHandler in such a way that it kills the process for all Errors(always) and kills the process for Exceptions only when the flag is true, this flag can be enabled for Executors and disabled for other daemons(Master, Worker and HistoryServer)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78404/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78404/testReport)** for PR 18357 at commit [`c6e71f8`](https://github.com/apache/spark/commit/c6e71f87b0e8adbeadf35be76072c833bdcb3331). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18357 **[Test build #78404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78404/testReport)** for PR 18357 at commit [`c6e71f8`](https://github.com/apache/spark/commit/c6e71f87b0e8adbeadf35be76072c833bdcb3331). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18357 LGTM. I thought we already did it :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18357 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/18357 > But can you double check that this change won't terminate a still-functional worker? The change doesn't impact/harm the fully functional Worker, SparkUncaughtExceptionHandler handles only when any thread gets terminated due to the exception thrown from it without handling. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18357 according to the JIRA, if the worker meets some unrecoverable issues and the state becomes DEAD, it seems make sense to terminate this worker as it's not functional. But can you double check that this change won't terminate a still-functional worker? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18357 AFAIK SparkUncaughtExceptionHandler is designed to make Executors fail fast, because Executors are relatively lightweight, but I'm not sure we can afford to let Workers, even the Master fail fast too. cc @cloud-fan for more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/18357 @jiangxb1987 Thanks for looking at this. Any one of the threads in Worker gets an exception which is unhandled then the thread gets terminated and process(Worker) keeps running, and the Worker doesn't perform the terminated thread functionality. One instance I mentioned in the JIRA description, where dispatcher-event thread got the exception and terminated, worker keeps running without performing the terminated thread functionality. I think we should handle this at the process level for all the threads, if any thread gets unhandled exception then the process(Worker) should exit instead of performing partial functionality. This PR code change would set the default UncaughtExceptionHandler as SparkUncaughtExceptionHandler and for any unhandled exception in any thread of the process, SparkUncaughtExceptionHandler handles the exception and exit the process with the appropriate exit code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18357 Could you elaborate on when we need this improvement? In fact I don't see much benefit of having this at first glance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18357: [SPARK-21146] [CORE] Worker should handle and shutdown w...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18357 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
