[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18811 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/18811 ok, have done. Thanks @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18811 Ah, I'm sorry I misled you a bit here @zuotingbing . Yes you found another unused variable, but, it's in code that is copied directly from Hive. I think we should leave HiveSessionImplwithUGI untouched. It makes it easier to patch it if we don't have custom changes. https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java If you'll back that out, and this is the only other change you found, I'll merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18811 **[Test build #3869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3869/testReport)** for PR 18811 at commit [`589af7a`](https://github.com/apache/spark/commit/589af7a478e256938ee41a41561f8cd8571c0199). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18811 **[Test build #3869 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3869/testReport)** for PR 18811 at commit [`589af7a`](https://github.com/apache/spark/commit/589af7a478e256938ee41a41561f8cd8571c0199). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/18811 Thanks @srowen , will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18811: [SPARK-21604][SQL] if the object extends Logging, i sugg...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18811 That looks removable, but this isn't really worth bothering with or opening a JIRA. Can you look for other unused log vars? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
