[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19142 NVM, I mean in the Spark code there're some intended empty "else" branch, are you going to add trace log to them all? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user liuxianjiao commented on the issue: https://github.com/apache/spark/pull/19142 @jerryshao so,what's the meaning of these empty 'else'? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19142 I'm -1 on this PR. This PR actually fix nothing instead of adding one trace log, also usually user will not enable trace log, so this one line fix is not so helpful. You can find many place in Spark where it has no "else" branch, are you going to fix them all? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user liuxianjiao commented on the issue: https://github.com/apache/spark/pull/19142 @srowen Thanks for your reply!We can let users know the theory of the restart of receiver by this PR.To be honest,the 'else' was redundancy,so I improve it by logtrace. To say the least,if this PR is not worthwhile and the 'else' do nothing,can we remove it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19142 I don't think this is worthwhile. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19142 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
