[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 okay, do you mean I need to change the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19143 You haven't actually added tests, and that's not all this PR does. At the least, this doesn't match the intent you describe, and should be closed. I'd back up and describe the test you want in the JIRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 @srowen Actually, I think this one makes sense. Because the two open test cases are tested, we connect the Cartesian product and the broadcast nested loop join. When we understand the two connections, from the side, we can open these two test cases to find out. Per Row (NS), for example, is much more delayed than our previous hash join. Second, in our JoinBenchmark test, the two test cases are missing. I wonder if you agree with this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 Leave a comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
