[GitHub] spark issue #19200: Get default Locale
Github user Gschiavon commented on the issue: https://github.com/apache/spark/pull/19200 Ok, I got it. I will do that then. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19200: Get default Locale
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19200 Ah, the problem is the reverse really, but there is a problem. `"...".format(...)` is locale-sensitive in Scala, and this is a place where that matters. The `Utils` method needs to change to use `formalLocal` with `Locale.US`. Open a JIRA for it, and close this and reopen vs `master` with that fix. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19200: Get default Locale
Github user Gschiavon commented on the issue: https://github.com/apache/spark/pull/19200 As far as I saw there are other test cases that set default locale to US. This case is not passing when your jvm default locale value differs from "US". --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19200: Get default Locale
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19200 No, because the project is purposely not locale sensitive at this level. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19200: Get default Locale
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19200 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
