[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/19217 @nivox can you please update the PR title when you get the chance? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19217 That sounds better. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user ash211 commented on the issue: https://github.com/apache/spark/pull/19217 How about `[SPARK-21991][LAUNCHER] Fix race condition in LauncherServer#acceptConnections` ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19217 The code LGTM, but the PR title should describe the fix, not the bug. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19217 Looks reasonable to me. @vanzin was this OK with you? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19217 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81741/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19217 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19217 **[Test build #81741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81741/testReport)** for PR 19217 at commit [`72af1aa`](https://github.com/apache/spark/commit/72af1aa212b645cd771e1b511f4c428f73743994). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19217 **[Test build #81741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81741/testReport)** for PR 19217 at commit [`72af1aa`](https://github.com/apache/spark/commit/72af1aa212b645cd771e1b511f4c428f73743994). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19217 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19217: [SPARK-21991][LAUNCHER] LauncherServer acceptConnections...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19217 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
