[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19231 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19231 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81800/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81800/testReport)** for PR 19231 at commit [`06095f5`](https://github.com/apache/spark/commit/06095f52454a000d15d3df5845a383cb1e1dbddc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81798/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81798/testReport)** for PR 19231 at commit [`1ee4ea0`](https://github.com/apache/spark/commit/1ee4ea0a23b257caa6c3fc7c2b2b73e154314f02). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81800/testReport)** for PR 19231 at commit [`06095f5`](https://github.com/apache/spark/commit/06095f52454a000d15d3df5845a383cb1e1dbddc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81798/testReport)** for PR 19231 at commit [`1ee4ea0`](https://github.com/apache/spark/commit/1ee4ea0a23b257caa6c3fc7c2b2b73e154314f02). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81790/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81790/testReport)** for PR 19231 at commit [`c0edad2`](https://github.com/apache/spark/commit/c0edad203499738a18e3798d43bb19433f4836ee). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19231
```
val metadata = new MetadataBuilder()
.putLong("scale", fieldScale)
val columnType =
dialect.getCatalystType(dataType, typeName, fieldSize,
metadata).getOrElse(
getCatalystType(dataType, fieldSize, fieldScale, isSigned))
fields(i) = StructField(columnName, columnType, nullable,
metadata.build())
```
->
```
val metadata = new MetadataBuilder()
.putLong("scale", fieldScale)
val columnType =
dialect.getCatalystType(dataType, typeName, fieldSize,
metadata).getOrElse(
getCatalystType(dataType, fieldSize, fieldScale, isSigned))
fields(i) = StructField(columnName, columnType, nullable)
```
Calling `dialect.getCatalystType` is before we setting the metadata of
`StructField `. Why we still need `scale`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81790/testReport)** for PR 19231 at commit [`c0edad2`](https://github.com/apache/spark/commit/c0edad203499738a18e3798d43bb19433f4836ee). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81758/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19231 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81758/testReport)** for PR 19231 at commit [`9e7a8a4`](https://github.com/apache/spark/commit/9e7a8a471835d5e93a729c15d166451e79567447). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19231: [SPARK-22002][SQL] Read JDBC table use custom schema sup...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19231 **[Test build #81758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81758/testReport)** for PR 19231 at commit [`9e7a8a4`](https://github.com/apache/spark/commit/9e7a8a471835d5e93a729c15d166451e79567447). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
