[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19247 Thanks! Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86288/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86288/testReport)** for PR 19247 at commit [`10106b3`](https://github.com/apache/spark/commit/10106b3213da1abd205c993a40f4ce025234f3e1). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class AddTextFileData(content: String, src: File, tmp: File, tmpFilePrefix: String = \"text\")` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86288/testReport)** for PR 19247 at commit [`10106b3`](https://github.com/apache/spark/commit/10106b3213da1abd205c993a40f4ce025234f3e1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19247 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86243/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86243/testReport)** for PR 19247 at commit [`10106b3`](https://github.com/apache/spark/commit/10106b3213da1abd205c993a40f4ce025234f3e1). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class AddTextFileData(content: String, src: File, tmp: File, tmpFilePrefix: String = \"text\")` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86243/testReport)** for PR 19247 at commit [`10106b3`](https://github.com/apache/spark/commit/10106b3213da1abd205c993a40f4ce025234f3e1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86241/testReport)** for PR 19247 at commit [`04c2b14`](https://github.com/apache/spark/commit/04c2b1443710609817c21d4707d589b6fc1af2de). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class AddTextFileData(content: String, src: File, tmp: File, tmpFileNamePrefix: String = \"text\")` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86241/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86241/testReport)** for PR 19247 at commit [`04c2b14`](https://github.com/apache/spark/commit/04c2b1443710609817c21d4707d589b6fc1af2de). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86237/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86237/testReport)** for PR 19247 at commit [`7342d6c`](https://github.com/apache/spark/commit/7342d6ced2db282ea5de76cda4957d735f806ef1). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 Hi @zsxwing I have pushed latest changes (for file sink I'll be honest I simply copied your code =p) I also verified that both tests would fail without the fix. Please review. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86237/testReport)** for PR 19247 at commit [`7342d6c`](https://github.com/apache/spark/commit/7342d6ced2db282ea5de76cda4957d735f806ef1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86132/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86132/testReport)** for PR 19247 at commit [`2542014`](https://github.com/apache/spark/commit/2542014b8769cb3a605ec03e3d1e45ff2ab81576). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86132/testReport)** for PR 19247 at commit [`2542014`](https://github.com/apache/spark/commit/2542014b8769cb3a605ec03e3d1e45ff2ab81576). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19247 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86130/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86130/testReport)** for PR 19247 at commit [`2542014`](https://github.com/apache/spark/commit/2542014b8769cb3a605ec03e3d1e45ff2ab81576). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86130/testReport)** for PR 19247 at commit [`2542014`](https://github.com/apache/spark/commit/2542014b8769cb3a605ec03e3d1e45ff2ab81576). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19247 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 hi @HyukjinKwon @zsxwing @mgaido91 i have updated code according to the comments, also merged with latest master. Please review. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 @joseph-torres @brkyvz @lw-lin can you please take a look? (sorry for uninvited mentions but i just took the latest commits on `FileStreamSource`) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user xysun commented on the issue: https://github.com/apache/spark/pull/19247 To handle file names with special characters, we should use `URI.getPath` to get decoded path, instead of using `toString`, which may contain other characters different from original path. java doc [here](https://docs.oracle.com/javase/8/docs/api/java/net/URI.html#getPath--) While this change fix the specific issue raised, I did a search and find multiple places in spark code where `URI.toString` is used. Should this be a concern? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
