[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19309
  
Thanks! Merged to master.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19309
  
LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82597/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82597 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82597/testReport)**
 for PR 19309 at commit 
[`bcc44e9`](https://github.com/apache/spark/commit/bcc44e9945f29f60a307bfa3a90225d4419622de).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/19309
  
That's basically what the PR summary says.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82597 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82597/testReport)**
 for PR 19309 at commit 
[`bcc44e9`](https://github.com/apache/spark/commit/bcc44e9945f29f60a307bfa3a90225d4419622de).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19309
  
Let me summarize the PR. Please correct me if anything is missing.

**Background**

Currently, our users can register a listener one by one during the 
executions by calling the SparkContext API:
>def addSparkListener(listener: SparkListenerInterface)

Users also can specify them through the Conf `spark.extraListeners`. 
SparkContext will automatically register the extra listeners during the 
initialization phase.

In Spark SQL, QueryExecutionListener enable users to register 
QueryExecutionListener by calling the API 
>def register(listener: QueryExecutionListener)

**Proposal**

This PR is proposing to add a similar static SQLConf 
`spark.sql.queryExecutionListeners`. When a Spark session is built/cloned, the 
query execution listeners specified in the new conf will be registered 
automatically.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-10-10 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19309
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19309
  
Will review it this weekend.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82287/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82287 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82287/testReport)**
 for PR 19309 at commit 
[`bcc44e9`](https://github.com/apache/spark/commit/bcc44e9945f29f60a307bfa3a90225d4419622de).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82287 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82287/testReport)**
 for PR 19309 at commit 
[`bcc44e9`](https://github.com/apache/spark/commit/bcc44e9945f29f60a307bfa3a90225d4419622de).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-25 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/19309
  
/cc @gatorsmile @cloud-fan 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82041/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19309
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-21 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82041 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82041/testReport)**
 for PR 19309 at commit 
[`c52fd71`](https://github.com/apache/spark/commit/c52fd71899b136d79202eeb2c6502e2845b19714).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `  s\"$name is not a subclass of $`
  * `.doc(\"List of class names implementing QueryExecutionListener 
that will be automatically \" +`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19309: [SPARK-19558][sql] Add config key to register QueryExecu...

2017-09-21 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19309
  
**[Test build #82041 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82041/testReport)**
 for PR 19309 at commit 
[`c52fd71`](https://github.com/apache/spark/commit/c52fd71899b136d79202eeb2c6502e2845b19714).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org