[GitHub] spark issue #19330: Orderable MapType
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19330 **[Test build #82173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82173/testReport)** for PR 19330 at commit [`33e532b`](https://github.com/apache/spark/commit/33e532b2d548bd482e0fe4ca645ad4261e900011). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/19330 @hvanhovell Thanks a lot for comment. I got you point. I will refine soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/19330 @hvanhovell : based on [your comment over the jira](https://issues.apache.org/jira/browse/SPARK-18134?focusedCommentId=15693519=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15693519), it seemed that the approach to be used is yet to be finalised. Are we moving ahead with this approach ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82107/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19330 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19330 **[Test build #82107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82107/testReport)** for PR 19330 at commit [`bd50495`](https://github.com/apache/spark/commit/bd504955d733834fb4b63623ab059294bbf91fc9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19330 @jinxing64 thanks for taking over. I have glanced over the PR, and I miss the explicit sorting of maps. We can't assume that maps are sorted out of the box, for example the following example should evaluate to `true` but it won't in your PR: `map(1, 2, 3, 4) = map(3, 4, 1, 2)`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19330 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82106/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19330 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19330 **[Test build #82106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82106/testReport)** for PR 19330 at commit [`2e2b98d`](https://github.com/apache/spark/commit/2e2b98d2fa9b399280cb4b5dbbfa1aadd3ede951). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19330 **[Test build #82107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82107/testReport)** for PR 19330 at commit [`bd50495`](https://github.com/apache/spark/commit/bd504955d733834fb4b63623ab059294bbf91fc9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/19330 It seems https://github.com/apache/spark/pull/15970 is not being worked. I resolved conflicts and add some tests in this pr. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19330: Orderable MapType
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19330 **[Test build #82106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82106/testReport)** for PR 19330 at commit [`2e2b98d`](https://github.com/apache/spark/commit/2e2b98d2fa9b399280cb4b5dbbfa1aadd3ede951). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
