[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
@jsnowacki, I happened to make another JIRA - 
https://issues.apache.org/jira/browse/SPARK-22495 for this PR. Mind linking 
this PR to the JIRA?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
@jsnowacki, sorry for being late again and again. Will probably take a 
final look once the comments are addressed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #83226 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83226/testReport)**
 for PR 19370 at commit 
[`8489a3c`](https://github.com/apache/spark/commit/8489a3c4dd7aa9c58cf6dd42f4ddb323457f8561).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I've fixed this `"delims="` part. Let me know if I should change something 
about the other comments as I explained why this is done like that.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
Sorry I kept you waiting. I'm a bit busy lately and I don't get the 
notifications unless I get called out.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
Hey @jsnowacki, would you maybe have some time to address the comments 
above?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
👍 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
@HyukjinKwon I've updated the PR description. Let me know if this is 
sufficient.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
@jsnowacki, per review comment - 
https://github.com/apache/spark/pull/19370#pullrequestreview-65758626, let's 
describe the background and the proposal in more details in the PR description. 
It is true it's the lack of reviewers for Windows specific issues and we should 
better describe it at our best.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
@HyukjinKwon this PR is hanging in there for a few days now. Should I need 
to do anything else or just wait for other reviews?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82510/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82510 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82510/testReport)**
 for PR 19370 at commit 
[`aec49a0`](https://github.com/apache/spark/commit/aec49a0f3027a7e2c0c83339232a37926db1d2dc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19370
  
I saw the same problem on github.com a couple of days 
ago. I think something is broken with the github integration but not sure how 
that is managed.






---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82508/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82508 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82508/testReport)**
 for PR 19370 at commit 
[`5f52c79`](https://github.com/apache/spark/commit/5f52c791cda81323ac985ce18796ea4131c30923).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
Yup, it looks triggering fine - 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1822-master
 although I wonder why check mark does not appear. I think it is not specific 
to this PR but rather AppVeyor itself though ..


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82510 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82510/testReport)**
 for PR 19370 at commit 
[`aec49a0`](https://github.com/apache/spark/commit/aec49a0f3027a7e2c0c83339232a37926db1d2dc).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
@HyukjinKwon Commit squashed to one as you've requested.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
Otherwise, looks good to me.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
@jsnowacki, would you mind if I ask squash those commits into single one so 
that we can check if the squashed commit, having the changes in `appveyor.yml` 
and `*.cmd`, actually triggers AppVeyor test?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82508 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82508/testReport)**
 for PR 19370 at commit 
[`5f52c79`](https://github.com/apache/spark/commit/5f52c791cda81323ac985ce18796ea4131c30923).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I've added `- bin/*.cmd` to the AppVeyor file. Please let me know if this 
is sufficient.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82416/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82416 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82416/testReport)**
 for PR 19370 at commit 
[`5ad1590`](https://github.com/apache/spark/commit/5ad15900aae54d7a9163f39eb2d4c5e585b13a53).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82414/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82414 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82414/testReport)**
 for PR 19370 at commit 
[`5ad1590`](https://github.com/apache/spark/commit/5ad15900aae54d7a9163f39eb2d4c5e585b13a53).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
add to whitelist


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82416 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82416/testReport)**
 for PR 19370 at commit 
[`5ad1590`](https://github.com/apache/spark/commit/5ad15900aae54d7a9163f39eb2d4c5e585b13a53).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82414 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82414/testReport)**
 for PR 19370 at commit 
[`5ad1590`](https://github.com/apache/spark/commit/5ad15900aae54d7a9163f39eb2d4c5e585b13a53).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
Done altering `run-example.cmd`.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82405/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82405 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82405/testReport)**
 for PR 19370 at commit 
[`d62ae59`](https://github.com/apache/spark/commit/d62ae59d892aa61a9f61af1411f2602a2b3e9ae1).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82405 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82405/testReport)**
 for PR 19370 at commit 
[`d62ae59`](https://github.com/apache/spark/commit/d62ae59d892aa61a9f61af1411f2602a2b3e9ae1).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82396/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82396 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82396/testReport)**
 for PR 19370 at commit 
[`d62ae59`](https://github.com/apache/spark/commit/d62ae59d892aa61a9f61af1411f2602a2b3e9ae1).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I've incorporated all of your comments and moved the CMD logic of finding 
SPARK_HOME into separate script. It has been tested locally and works fine. It 
will complain if Python is not installed, but I don't have a better way around 
it really. It will try to run in only when `find_spark_home.py` is present in 
the current directory, so I assume this will only happen when it is installed 
via `pip` so there should be python somewhere there.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82396 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82396/testReport)**
 for PR 19370 at commit 
[`d62ae59`](https://github.com/apache/spark/commit/d62ae59d892aa61a9f61af1411f2602a2b3e9ae1).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82380/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82380 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82380/testReport)**
 for PR 19370 at commit 
[`3ac2c86`](https://github.com/apache/spark/commit/3ac2c8623bf53168cb815b28eeb0f880d1e76d3a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82380 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82380/testReport)**
 for PR 19370 at commit 
[`3ac2c86`](https://github.com/apache/spark/commit/3ac2c8623bf53168cb815b28eeb0f880d1e76d3a).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I've explained it in the ticket 
https://issues.apache.org/jira/browse/SPARK-18136. 

> I think in a long run it would be better to move to some Python packaging 
mechanisms like console_scripts or related, as it will provide better 
multiplatform support; see 
https://packaging.python.org/tutorials/distributing-packages/#scripts and 
https://setuptools.readthedocs.io/en/latest/setuptools.html#automatic-script-creation.
 I'll create a separate issue with improvement proposal.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19370
  
what is this python console scripts idea, @jsnowacki ?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
Moving it to Python script sounds a good idea to me if possible in the 
future.I did have the smae concern with @felixcheung but to me okay to add it 
after reading the comment above.

Let's add comments in more details in the new script for followups in the 
future.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I don't want to move the python logic into CMD. I'll move the current 
checks I've added to a separate file and extend them into one or two additional 
cases similar to the bash script {{find_spark_home}}. This will put the 
business logic of finding spark on windows into one file, which is better for 
maintenance. In the long run I'd suggest moving to a more portable solution 
like the python console scripts I suggested above.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19370
  
I'm not sure about duplicating the entire logic in find_spark into a 
windows version though - given how poorly maintained things are on windows (to 
be honest) I worry about any addition of code 



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[jsnowacki]

Github user jsnowacki commented on the issue:

https://github.com/apache/spark/pull/19370
  
I'll move out the codes to a separate `find_spark_home.cmd`, similar to the 
bash version, which will take into account the above comments. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82258/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82258 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82258/testReport)**
 for PR 19370 at commit 
[`0b12975`](https://github.com/apache/spark/commit/0b12975b0d224ed4173616b34106c3c3911371b9).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
cc @holdenk, @felixcheung and @ueshin who I believe are interested in this.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19370
  
**[Test build #82258 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82258/testReport)**
 for PR 19370 at commit 
[`0b12975`](https://github.com/apache/spark/commit/0b12975b0d224ed4173616b34106c3c3911371b9).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19370
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19370: [SPARK-18136] Fix setup of SPARK_HOME variable on Window...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19370
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org