[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19494 I created the followup PR: https://github.com/apache/spark/pull/19522. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19494 I will, thanks for your suggestions @gatorsmile. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19494 I will not revert this PR but please submit the fix ASAP. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19494 Sorry for my late review. @mgaido91 Could you submit a follow-up PR to address my comments. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19494 Merged to master/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19494 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19494 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82789/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19494 **[Test build #82789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82789/testReport)** for PR 19494 at commit [`f5bc105`](https://github.com/apache/spark/commit/f5bc10582f60bf130af1fefed5b9dc9fb3e748d9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19494 **[Test build #82789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82789/testReport)** for PR 19494 at commit [`f5bc105`](https://github.com/apache/spark/commit/f5bc10582f60bf130af1fefed5b9dc9fb3e748d9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19494 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19494 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82780/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19494 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19494 **[Test build #82780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82780/testReport)** for PR 19494 at commit [`f5bc105`](https://github.com/apache/spark/commit/f5bc10582f60bf130af1fefed5b9dc9fb3e748d9). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19494 **[Test build #82780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82780/testReport)** for PR 19494 at commit [`f5bc105`](https://github.com/apache/spark/commit/f5bc10582f60bf130af1fefed5b9dc9fb3e748d9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19494 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19494 @srowen I also updated the UT to check all the possible cases. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19494 @srowen do you mean replacing `contains` with `exists`? If so, might you please explain me why `exists` is a better option? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19494: [SPARK-22249][SQL] isin with empty list throws exception...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19494 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
