[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19537 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19537 **[Test build #3953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3953/testReport)** for PR 19537 at commit [`69f041f`](https://github.com/apache/spark/commit/69f041f1420be262006163bb64c39daa205e7209). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19537 **[Test build #3953 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3953/testReport)** for PR 19537 at commit [`69f041f`](https://github.com/apache/spark/commit/69f041f1420be262006163bb64c39daa205e7209). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user ericjperry commented on the issue: https://github.com/apache/spark/pull/19537 @srowen not that I noticed during my reading at least. I can't speak much about classes outside of the SQL portion of the project, though. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19537 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19537: [SQL] Mark strategies with override for clarity.
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19537 I think that's OK. Are there other instances where something could `override` but doesn't? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
