[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83506/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83506/testReport)** for PR 19553 at commit [`91cdfef`](https://github.com/apache/spark/commit/91cdfef4bcd743635b68ace1dafac309af76289c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83506/testReport)** for PR 19553 at commit [`91cdfef`](https://github.com/apache/spark/commit/91cdfef4bcd743635b68ace1dafac309af76289c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 Ye, why not, let's continue this circle ;) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 @Whoosh do you have time for one more change to bring this full circle, back to catching exceptions? looks like there was a reason that was necessary. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 @cloud-fan yeah I'm OK coming full circle on this one. I had hoped to avoid it with a simpler mechanism but didn't see that it wouldn't actually work. I apologize to @Whoosh for the run-around. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 how about we just try catch the ClassCastException? introducing class tag has serialization overhead. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 If for some reason this last approach can't be made to work, we could just fall back to catching the exception. Because it shouldn't happen in any normal use, it doesn't matter much. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83321 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83321/testReport)** for PR 19553 at commit [`c4bd531`](https://github.com/apache/spark/commit/c4bd5311ce0fc733659afc02aff6c1c7e02e13ab). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83321/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83321/testReport)** for PR 19553 at commit [`c4bd531`](https://github.com/apache/spark/commit/c4bd5311ce0fc733659afc02aff6c1c7e02e13ab). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 Ping @Whoosh --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83198/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83198/testReport)** for PR 19553 at commit [`235f6d6`](https://github.com/apache/spark/commit/235f6d67cf25f4016c8e8ffb77103770e855ec62). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Whoosh commented on the issue: https://github.com/apache/spark/pull/19553 @cloud-fan I've checked all core tests, it was fine, should I do smt in addition to? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #83198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83198/testReport)** for PR 19553 at commit [`235f6d6`](https://github.com/apache/spark/commit/235f6d67cf25f4016c8e8ffb77103770e855ec62). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19553 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 @Tagar it's the same general type of issue, but not directly related nor exactly the same cause. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user Tagar commented on the issue: https://github.com/apache/spark/pull/19553 @Whoosh can you please check if there is a similar problem that affects [SPARK-21657](https://issues.apache.org/jira/browse/SPARK-21657?focusedCommentId=16220469=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16220469) ? thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #3962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3962/testReport)** for PR 19553 at commit [`f2cbb0c`](https://github.com/apache/spark/commit/f2cbb0c9278ad7230d54bf00ccce1ff1bcdf75f7). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19553 **[Test build #3962 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3962/testReport)** for PR 19553 at commit [`f2cbb0c`](https://github.com/apache/spark/commit/f2cbb0c9278ad7230d54bf00ccce1ff1bcdf75f7). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19553 Ping @Whoosh --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19553: [SPARK-22330][CORE] Linear containsKey operation for ser...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19553 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
