[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/19587
  
LGTM, merging to master!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83160/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83160 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83160/testReport)**
 for PR 19587 at commit 
[`624736e`](https://github.com/apache/spark/commit/624736ea31151f978dbdc56d81dda7f8d192).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19587
  
LGTM too


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83160 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83160/testReport)**
 for PR 19587 at commit 
[`624736e`](https://github.com/apache/spark/commit/624736ea31151f978dbdc56d81dda7f8d192).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83154 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83154/testReport)**
 for PR 19587 at commit 
[`ea20b03`](https://github.com/apache/spark/commit/ea20b039f07424eb574679cd53e31b704e50abf2).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83154/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83154 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83154/testReport)**
 for PR 19587 at commit 
[`ea20b03`](https://github.com/apache/spark/commit/ea20b039f07424eb574679cd53e31b704e50abf2).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19587
  
Could you add a comment in `abstract class QueryPlan`'s conf? Hopefully, 
the others will read the comment before using it. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread viirya
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/19587
  
LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread BryanCutler
Github user BryanCutler commented on the issue:

https://github.com/apache/spark/pull/19587
  
LGTM, good catch!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83130/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83130 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83130/testReport)**
 for PR 19587 at commit 
[`b47f55b`](https://github.com/apache/spark/commit/b47f55b8e2eb0de99ddb94cd1b96423f0ddcf1a4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83130 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83130/testReport)**
 for PR 19587 at commit 
[`b47f55b`](https://github.com/apache/spark/commit/b47f55b8e2eb0de99ddb94cd1b96423f0ddcf1a4).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread icexelloss
Github user icexelloss commented on the issue:

https://github.com/apache/spark/pull/19587
  
LGTM. +1


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83118/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19587
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83118 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83118/testReport)**
 for PR 19587 at commit 
[`0918872`](https://github.com/apache/spark/commit/091887255ff2caa9b3e6691321407b86977bf513).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread ueshin
Github user ueshin commented on the issue:

https://github.com/apache/spark/pull/19587
  
cc @BryanCutler @icexelloss @cloud-fan @gatorsmile 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/19587
  
**[Test build #83118 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83118/testReport)**
 for PR 19587 at commit 
[`0918872`](https://github.com/apache/spark/commit/091887255ff2caa9b3e6691321407b86977bf513).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org