[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 thanks everyone. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19661 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83676/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83676/testReport)** for PR 19661 at commit [`77f994f`](https://github.com/apache/spark/commit/77f994fcb83af482ddf4e851cb662486db095090). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83676/testReport)** for PR 19661 at commit [`77f994f`](https://github.com/apache/spark/commit/77f994fcb83af482ddf4e851cb662486db095090). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83665/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83665/testReport)** for PR 19661 at commit [`d7090bb`](https://github.com/apache/spark/commit/d7090bbf60ea98e9ade9534b78e249b0f25621e4). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19661 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83665/testReport)** for PR 19661 at commit [`d7090bb`](https://github.com/apache/spark/commit/d7090bbf60ea98e9ade9534b78e249b0f25621e4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83642/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83642/testReport)** for PR 19661 at commit [`2eb1b62`](https://github.com/apache/spark/commit/2eb1b62c6fb281f89f05aa8a3c0fcd923ed62cf4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19661 **[Test build #83642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83642/testReport)** for PR 19661 at commit [`2eb1b62`](https://github.com/apache/spark/commit/2eb1b62c6fb281f89f05aa8a3c0fcd923ed62cf4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19661 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 Thanks for reviewing. The code is updated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 >So why don't you include some classes such as org.apache.spark.ml.feature.Instance ? I'm not family with those algorithm, I can add them such as `org.apache.spark.ml.feature.Instance` . If this method is not reasonable, we maybe just reminder user to register them in the doc. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19661 And I don't know whether these class dependency injection into spark-core lib is reasonable ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19661 So why do you include the class such as `org.apache.spark.ml.feature.Instance`. You can look into a lot of algos, in `ml` package (not `mllib`), still use something like `RDD[Instance]` and cache them, (these algos only interface use dataframe). such as LinearRegression, LogisticRegression and so on. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19661 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19661: [SPARK-22450][Core][Mllib]safely register class for mlli...
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/19661 #19586 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
