[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-12 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19722
  
Thank you @srowen and @felixcheung for review! and thanks @mgaido91 and 
@dongjoon-hyun for your thumbs up :D.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-12 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19722
  
merged to master/cherry pick to 2.2


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/19722
  
LGTM cool stuff, if we get the same result in less iterations

Let’s get this into 2.2 as well




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19722
  
cc @felixcheung and @shivaram too. This one finally reduces the time!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19722: [SPARK-21693][R][ML] Reduce max iterations in Linear SVM...

2017-11-11 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/19722
  
Yea, the first build speeded up roughly about 30 minutes - 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1909-master.
 I triggered more builds here for sure with my account..


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org