[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84293/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit [`5332f12`](https://github.com/apache/spark/commit/5332f1280b53aa760f193383104574256a1caa9e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 LGTM, can you remove `WIP` in PR title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit [`5332f12`](https://github.com/apache/spark/commit/5332f1280b53aa760f193383104574256a1caa9e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19821 Sure, I have resolved the conflict in my environment. I will commit soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 @kiszk Can you fix the conflict? now we can add a middle-advanced version: ``` def splitExpressions( expressions: Seq[String], funcName: String, extraArguments: Seq[(String, String)]) ``` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19821 I have no strong preference. @gatorsmile WDYT? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 is it really worth? seems not used in many places and eventually the if-else will be removed after we make `splitExpression` work with whole stage codegen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84191/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84191/testReport)** for PR 19821 at commit [`7b6526a`](https://github.com/apache/spark/commit/7b6526a73f59259b2c29cfae04845e9c511cc32f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84191/testReport)** for PR 19821 at commit [`7b6526a`](https://github.com/apache/spark/commit/7b6526a73f59259b2c29cfae04845e9c511cc32f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
