[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20010 I think this is already fixed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91613/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #91613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91613/testReport)** for PR 20010 at commit [`09e49fb`](https://github.com/apache/spark/commit/09e49fb8162b97dec76a6324fa4fac4553b22013). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #91613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91613/testReport)** for PR 20010 at commit [`09e49fb`](https://github.com/apache/spark/commit/09e49fb8162b97dec76a6324fa4fac4553b22013). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20010 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20010 @bdrillard I think that we need to know Hive's behavior as per https://github.com/apache/spark/pull/20010#issuecomment-355717067 to state which is the preferred/right behavior here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/20010 Is there a consensus on the preferred behavior here? This issue would also be a blocker to encoders for Spark-Avro in Spark 2.3.0 that @marmbrus mentions in #20085. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20010 Overall, it is reasonable. What is the current behavior in Hive? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85682/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85682/testReport)** for PR 20010 at commit [`09e49fb`](https://github.com/apache/spark/commit/09e49fb8162b97dec76a6324fa4fac4553b22013). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85682/testReport)** for PR 20010 at commit [`09e49fb`](https://github.com/apache/spark/commit/09e49fb8162b97dec76a6324fa4fac4553b22013). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20010 Will review it today. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/20010 /cc @cloud-fan @sameeragarwal --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85526/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85526/testReport)** for PR 20010 at commit [`d42dfa5`](https://github.com/apache/spark/commit/d42dfa55105c8944b63781fc61b59c98a99338d1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85526/testReport)** for PR 20010 at commit [`d42dfa5`](https://github.com/apache/spark/commit/d42dfa55105c8944b63781fc61b59c98a99338d1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85521/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85521/testReport)** for PR 20010 at commit [`7d146e3`](https://github.com/apache/spark/commit/7d146e313cfd9ecf8c47f046028d9ff70f0301d3). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85515/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85515/testReport)** for PR 20010 at commit [`23c83ac`](https://github.com/apache/spark/commit/23c83ac7e13bbf23347ff14b65a2413342aae00f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85521/testReport)** for PR 20010 at commit [`7d146e3`](https://github.com/apache/spark/commit/7d146e313cfd9ecf8c47f046028d9ff70f0301d3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85520/testReport)** for PR 20010 at commit [`e034bbc`](https://github.com/apache/spark/commit/e034bbcad245e57c8c0276b669303c1d70504f5a). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85520/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85520/testReport)** for PR 20010 at commit [`e034bbc`](https://github.com/apache/spark/commit/e034bbcad245e57c8c0276b669303c1d70504f5a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85515/testReport)** for PR 20010 at commit [`23c83ac`](https://github.com/apache/spark/commit/23c83ac7e13bbf23347ff14b65a2413342aae00f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85514/testReport)** for PR 20010 at commit [`583f674`](https://github.com/apache/spark/commit/583f6748e5678417fce817b829acf6151f166e92). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85514/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85514/testReport)** for PR 20010 at commit [`583f674`](https://github.com/apache/spark/commit/583f6748e5678417fce817b829acf6151f166e92). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20010 @gczsjdy @bdrillard the test errors are valid. In some cases an exception is expected to be thrown, but it isn't, due to the fix. So they should be updated accordingly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85497/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85497/testReport)** for PR 20010 at commit [`86e1929`](https://github.com/apache/spark/commit/86e1929c490861d9e93ef34abd52c442f99f31a9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85497/testReport)** for PR 20010 at commit [`86e1929`](https://github.com/apache/spark/commit/86e1929c490861d9e93ef34abd52c442f99f31a9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/20010 Seems not a regular error? @bdrillard Maybe you can push a commit and trigger the test again. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20010 Thanks @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85447/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85447/testReport)** for PR 20010 at commit [`8ce3b39`](https://github.com/apache/spark/commit/8ce3b39369266b222323561afd431ecfe0dc5270). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20010 **[Test build #85447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85447/testReport)** for PR 20010 at commit [`8ce3b39`](https://github.com/apache/spark/commit/8ce3b39369266b222323561afd431ecfe0dc5270). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20010 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20010 @HyukjinKwon Can you help trigger Jenkins test for this? Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/20010 @mgaido91 Agreed with that concern. I think the last round of tests I've just added covers the permutation of cases well, where we have arrays and maps of structs, and structs of arrays and maps. cc: @viirya, @gatorsmile, Could perhaps one of you trigger a Jenkins build against this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20010 @bdrillard yes, after addressing my last comments I think we can build this. My only concern is that we are not covering the case in which there are nested complex structures in the wider case. But maybe we can address this later. I don't have permissions to trigger a build. You might check who are the last committers working on this and maybe ask them. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user bdrillard commented on the issue: https://github.com/apache/spark/pull/20010 @gczsjdy, @mgaido91 If you all are comfortable with it, I think this PR is in a state where we could trigger a build. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over Struct...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20010 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
