[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 OK, I will do it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20119 > @zsxwing maybe we only need to fix above two points related to external shuffle service, what do you think? @jerryshao sgtm. Could you submit a PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 @zsxwing maybe we only need to fix above two points related to external shuffle service, what do you think? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 Sorry I haven't checked the details, let me take a look at it. The changes I made was trying to fix memory issue for shuffle (especially external shuffle service), this issue was occurred in our prod cluster. Let me think if there's a way to fix it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20119 let's also cc the author. @jerryshao do you know if there is a way to fix the regression? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20119 Thanks! Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20119 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85532/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20119 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20119 **[Test build #85532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85532/testReport)** for PR 20119 at commit [`401d650`](https://github.com/apache/spark/commit/401d65047cc2b9b920243e0df7b2802929a6bc56). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20119 **[Test build #85532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85532/testReport)** for PR 20119 at commit [`401d650`](https://github.com/apache/spark/commit/401d65047cc2b9b920243e0df7b2802929a6bc56). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org