[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2018-10-11 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20125
  
I am sorry it's been inactive. Let me update this one within a week.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20125
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread AmplabJenkins 
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20125
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/8/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20125
  
**[Test build #8 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/8/testReport)**
 for PR 20125 at commit 
[`5cae64b`](https://github.com/apache/spark/commit/5cae64b0da57a3f45b54bcc39c18463d3945a934).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20125
  
I actually think 
https://github.com/apache/spark/pull/20125#issuecomment-354604768 are good 
points and I was hesitant about it. Although IMHO I think it's fine but let me 
cc @hvanhovell and @rxin too, who reviewed my related PRs before.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20125
  
> Btw, is this any difference than using string? Like:

Nope, they will be the same but I was thinking this is a simplest fix.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20125
  
Yup, I was thinking of SparkSQL only feature.

For more details, the original intention was to support multiple values for 
`nullValue` but I realised such option support can be generallised - there were 
several issues about this since CSV is thirdparty library (I will find and give 
some links if requested). Also, there is one reference in R too:

```R
> d <- "col1,col2
+ 1,3
+ 2,4"
> df <- read.csv(text=d, na.strings=c("3", "2"))
> df
```
```
  col1 col2
11   NA
2   NA4
```

For more context, original proposal (Scala/SQL/Python/Java) here - 
https://github.com/apache/spark/pull/16611 touched many files and I received an 
advice to make this smaller, which I liked.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread viirya 
Github user viirya commented on the issue:

https://github.com/apache/spark/pull/20125
  
Is this a special feature for SparkSQL only? Seems Hive doesn't have such 
support.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread SparkQA 
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20125
  
**[Test build #8 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/8/testReport)**
 for PR 20125 at commit 
[`5cae64b`](https://github.com/apache/spark/commit/5cae64b0da57a3f45b54bcc39c18463d3945a934).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20125: [SPARK-17967][SQL] Support for array as an option in SQL...

2017-12-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20125
  
cc @gatorsmile could you take a look please?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org