[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20132 Thanks! Merging with master and branch-2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20132 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85719/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20132 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20132 **[Test build #85719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85719/testReport)** for PR 20132 at commit [`c547d0f`](https://github.com/apache/spark/commit/c547d0fa7c4e1bb61312219df4d273af4a5a9db9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20132 **[Test build #85719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85719/testReport)** for PR 20132 at commit [`c547d0f`](https://github.com/apache/spark/commit/c547d0fa7c4e1bb61312219df4d273af4a5a9db9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20132 Updated! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20132 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20132 The simplified logic for encoder looks good to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20132 @jkbradley Thanks for this follow-up! I've noticed that first issue in original PR. But don't have enough time to discuss with you further. I'll go through this soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20132 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85569/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20132 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20132 **[Test build #85569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85569/testReport)** for PR 20132 at commit [`9bf045d`](https://github.com/apache/spark/commit/9bf045da1adeaa08deeb96eaa0289d8d4cb74bc1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20132 @viirya This basically has 2 changes: * configedCategorySize: my mistake! * encoder: clarify what I meant before --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org