[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20152 LGTM, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85684/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85684/testReport)** for PR 20152 at commit [`448dcce`](https://github.com/apache/spark/commit/448dcce0f97e15ce2d0265db9d7d334ab271126b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user rxin commented on the issue: https://github.com/apache/spark/pull/20152 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85684/testReport)** for PR 20152 at commit [`448dcce`](https://github.com/apache/spark/commit/448dcce0f97e15ce2d0265db9d7d334ab271126b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85680/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85680 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85680/testReport)** for PR 20152 at commit [`e32f254`](https://github.com/apache/spark/commit/e32f254843fb2d18a7fa6fc33f8a6d4026d242fa). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` case class Stats(value: Double, g: Long, delta: Long)` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user juliuszsompolski commented on the issue: https://github.com/apache/spark/pull/20152 If the serialized form change is a problem, that part can probably be reverted - it's far less likely that a single compressed stats chunk will overflow Int. The bug I hit was in the global rank counter part, and I changed the other part just by reviewing the code around for other places that could conceivably use a Long instead of Int. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20152 Seems reasonable; @clockfly what do you think? The serialized form changed here, but I'm not sure we'd guarantee compatibility there. This isn't something serialized to files for long-term storage is it? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85680 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85680/testReport)** for PR 20152 at commit [`e32f254`](https://github.com/apache/spark/commit/e32f254843fb2d18a7fa6fc33f8a6d4026d242fa). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85679/testReport)** for PR 20152 at commit [`324218b`](https://github.com/apache/spark/commit/324218b6065f1ad57479d5ee582694826c1309f9). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85679/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20152 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20152: [SPARK-22957] ApproxQuantile breaks if the number of row...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20152 **[Test build #85679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85679/testReport)** for PR 20152 at commit [`324218b`](https://github.com/apache/spark/commit/324218b6065f1ad57479d5ee582694826c1309f9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
