[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20166 ok, I'll fix struct in a next following pr first. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20166 merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20166
I think this is a bug, in `Dataset.showString` I see code like
```
case seq: Seq[_] => seq.mkString("[", ", ", "]")
```
Which means we do want to show strings like `[[1, 2], [3], [4, 5, 6]]`
Anyway let's fix in another PR, I'm merging this PR first
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85751/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85751 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85751/testReport)** for PR 20166 at commit [`fb11796`](https://github.com/apache/spark/commit/fb1179698c5a4cdfd13bbc4fa2a0ceda07fe43c9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20166
BTW, the current `Datset.showString` prints rows thru `RowEncoder`
deserializers like;
```
scala> Seq(Seq(Seq(1, 2), Seq(3), Seq(4, 5, 6))).toDF("a").show(false)
++
|a |
++
|[WrappedArray(1, 2), WrappedArray(3), WrappedArray(4, 5, 6)]|
++
```
If [we cast them before
prints](https://github.com/apache/spark/compare/master...maropu:CastToStringInShowString),
we could get more simpler forms like;
```
scala> Seq(Seq(Seq(1, 2), Seq(3), Seq(4, 5, 6))).toDF("a").show(false)
++
|a |
++
|[[1, 2], [3], [4, 5, 6]]|
++
```
I'm not sure through, is this acceptable? (Probably, we might need to add a
option to keep the old behaviour)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85751/testReport)** for PR 20166 at commit [`fb11796`](https://github.com/apache/spark/commit/fb1179698c5a4cdfd13bbc4fa2a0ceda07fe43c9). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20166 LGTM except one minor comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20166 @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85727/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85727/testReport)** for PR 20166 at commit [`be04e64`](https://github.com/apache/spark/commit/be04e64733d6051864d6597420d2c982c72606e6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85726/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20166 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85726/testReport)** for PR 20166 at commit [`efc28e3`](https://github.com/apache/spark/commit/efc28e3aa2a0add8e325d60162090c9ee3fdfcba). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85727/testReport)** for PR 20166 at commit [`be04e64`](https://github.com/apache/spark/commit/be04e64733d6051864d6597420d2c982c72606e6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20166: [SPARK-22973][SQL] Fix incorrect results of Casting Map ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20166 **[Test build #85726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85726/testReport)** for PR 20166 at commit [`efc28e3`](https://github.com/apache/spark/commit/efc28e3aa2a0add8e325d60162090c9ee3fdfcba). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
