[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20237
  
Hey @gatorsmile, @ueshin, @BryanCutler and @icexelloss. Let's fix this by 
clarifying it to avoid potential confusion for now and clear up SPARK-22216's 
subtasks.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20237
  
**[Test build #85974 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85974/testReport)**
 for PR 20237 at commit 
[`d2cfed3`](https://github.com/apache/spark/commit/d2cfed308d343fb55c5fd7c0d30bcbb987948632).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread icexelloss
Github user icexelloss commented on the issue:

https://github.com/apache/spark/pull/20237
  
@HyukjinKwon Thanks! I think this is good.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20237
  
**[Test build #85974 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85974/testReport)**
 for PR 20237 at commit 
[`d2cfed3`](https://github.com/apache/spark/commit/d2cfed308d343fb55c5fd7c0d30bcbb987948632).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20237
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20237
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85974/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20237
  
**[Test build #86025 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86025/testReport)**
 for PR 20237 at commit 
[`0fa39d0`](https://github.com/apache/spark/commit/0fa39d06d0a49773aee147da368e49d54ebd6e7b).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20237
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20237
  
**[Test build #86025 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86025/testReport)**
 for PR 20237 at commit 
[`0fa39d0`](https://github.com/apache/spark/commit/0fa39d06d0a49773aee147da368e49d54ebd6e7b).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20237
  
Merged to master and branch-2.3.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/20237
  
Only `length` is the common functions? 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20237
  
No, there are many other functions but this specific case could bring 
confusion as the length is not the length of the value and also not the length 
of the whole input column. In other cases, usually calling other functions on 
the pandas series produce expected results. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/20237
  
The newly added description is not clear to most Spark users. I think the 
descriptions added by this PR does not explain the common error cases pointed 
out in the JIRA.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20237: [SPARK-22980][PYTHON][SQL] Clarify the length of each se...

2018-01-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20237
  
Mind if I ask what you expect to fix @gatorsmile? It's clear and explans 
the results.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org