[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread maropu
Github user maropu commented on the issue:

https://github.com/apache/spark/pull/20245
  
yea, it's a super corner-case (almost impossible). So, this is just a 
correctness issue as intellij suggests incompatible comparisons. (Actually, I'm 
not sure why we use `BigInt` for the statistics for `Long`)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/20245
  
Do these values actually take on values larger than Long.MaxValue?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86029/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86029 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86029/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86029 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86029/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread maropu
Github user maropu commented on the issue:

https://github.com/apache/spark/pull/20245
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86024 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86024/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).
 * This patch **fails due to an unknown error code, -9**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86024/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86024 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86024/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread maropu
Github user maropu commented on the issue:

https://github.com/apache/spark/pull/20245
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20245
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86019/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86019 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86019/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread maropu
Github user maropu commented on the issue:

https://github.com/apache/spark/pull/20245
  
nitpicking though, could you check? @gatorsmile @wzhfy @mbasmanova


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20245: [SPARK-21213][SQL][FOLLOWUP] Use compatible types for co...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20245
  
**[Test build #86019 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86019/testReport)**
 for PR 20245 at commit 
[`473b37a`](https://github.com/apache/spark/commit/473b37a1d2abd74f66d29883a1e8bb488cf6bb94).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org