[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86211/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86211/testReport)** for PR 20254 at commit [`0b51997`](https://github.com/apache/spark/commit/0b51997b49d116691f90b8a4a988b4c55d201fdc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20254 @henryr Since Spark 2.3, Spark SQL documents all the behavior changes in [Migration Guides](https://spark.apache.org/docs/latest/sql-programming-guide.html#migration-guide). Hopefully, this can help our end users. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20254 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86211/testReport)** for PR 20254 at commit [`0b51997`](https://github.com/apache/spark/commit/0b51997b49d116691f90b8a4a988b4c55d201fdc). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user henryr commented on the issue: https://github.com/apache/spark/pull/20254 Thanks all for the pointers and feedback! I've removed the references to the behavior before 2.0, and now the changes just make it explicit that this is `EXCEPT DISTINCT` (I appreciate that that's the meaning of `EXCEPT` per ANSI, but the behavior change since 1.x has confused users I've spoken to so seems worthwhile to make the documentation as clear as possible). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20254 Just FYI, in ANSI SQL, `EXCEPT` = `EXCEPT DISTINCT` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20254 @henryr could you update this PR to only include EXCEPT DISTINCT without the notes --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20254 Yeah, we should document the behavior changes, but that was just a bug fix for 100% following the semantics of ANSI-SQL `EXCEPT DISTINCT` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20254 I see, from reading that PR I think perhaps we should reference migration guide in sql programming guide instead of putting the whole description here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20254 Also, cc @gatorsmile . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86068/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86068/testReport)** for PR 20254 at commit [`5562a16`](https://github.com/apache/spark/commit/5562a1665bebf413d5c4126642a77e2d9d0c4a46). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86067/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20254 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86067/testReport)** for PR 20254 at commit [`9fe5707`](https://github.com/apache/spark/commit/9fe57074b496ad95411c4ce5a43b0c43dd6246af). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86068/testReport)** for PR 20254 at commit [`5562a16`](https://github.com/apache/spark/commit/5562a1665bebf413d5c4126642a77e2d9d0c4a46). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user henryr commented on the issue: https://github.com/apache/spark/pull/20254 Done, thanks for pointing that out! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20254: [SPARK-23062][SQL] Improve EXCEPT documentation
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20254 **[Test build #86067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86067/testReport)** for PR 20254 at commit [`9fe5707`](https://github.com/apache/spark/commit/9fe57074b496ad95411c4ce5a43b0c43dd6246af). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
