[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 Merged to master / branch-2.3, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20257 Nice, LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86269/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86269/testReport)** for PR 20257 at commit [`3c697bd`](https://github.com/apache/spark/commit/3c697bd069519b99f19796d7f173655ffccefb50). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86269/testReport)** for PR 20257 at commit [`3c697bd`](https://github.com/apache/spark/commit/3c697bd069519b99f19796d7f173655ffccefb50). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 A couple minor comments, otherwise looks fine. I see we are changing the example names, so effectively removing the old examples. I'm ok with this, unless others have an objection? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86263/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86263/testReport)** for PR 20257 at commit [`18cf226`](https://github.com/apache/spark/commit/18cf226157d487faeab54d080862dae03b82de86). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86263/testReport)** for PR 20257 at commit [`18cf226`](https://github.com/apache/spark/commit/18cf226157d487faeab54d080862dae03b82de86). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick Changed as you suggested. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 Added a few more small comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86244/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86244/testReport)** for PR 20257 at commit [`e57d9ee`](https://github.com/apache/spark/commit/e57d9ee605256731f4514f8d381f985696ff8dea). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick @WeichenXu123 Your comments are addressed. Please check this again. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86244/testReport)** for PR 20257 at commit [`e57d9ee`](https://github.com/apache/spark/commit/e57d9ee605256731f4514f8d381f985696ff8dea). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)** for PR 20257 at commit [`262c046`](https://github.com/apache/spark/commit/262c0461bd5226b2e99ca5b0c35cf2a372a4892c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86153/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)** for PR 20257 at commit [`262c046`](https://github.com/apache/spark/commit/262c0461bd5226b2e99ca5b0c35cf2a372a4892c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick Thanks for review. I think I've addressed all the comments. Please take a look for the updates. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86117/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86117/testReport)** for PR 20257 at commit [`21cb7d3`](https://github.com/apache/spark/commit/21cb7d333f7a1a2f80f205a2fea7ec36fad3daaa). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public class JavaOneHotEncoderEstimatorExample ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86117/testReport)** for PR 20257 at commit [`21cb7d3`](https://github.com/apache/spark/commit/21cb7d333f7a1a2f80f205a2fea7ec36fad3daaa). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 cc @jkbradley @MLnick @WeichenXu123 I think we should update mllib document and example for OneHotEncoderEstimator in 2.3.0. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86089/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86089/testReport)** for PR 20257 at commit [`05577df`](https://github.com/apache/spark/commit/05577dff9d387967641e1e896014e7e3673ea998). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public class JavaOneHotEncoderEstimatorExample ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86089/testReport)** for PR 20257 at commit [`05577df`](https://github.com/apache/spark/commit/05577dff9d387967641e1e896014e7e3673ea998). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86087/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86087/testReport)** for PR 20257 at commit [`4e8f856`](https://github.com/apache/spark/commit/4e8f856d4b18b16a23697de0e2322197479a5d0c). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public class JavaOneHotEncoderEstimatorExample ` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86087/testReport)** for PR 20257 at commit [`4e8f856`](https://github.com/apache/spark/commit/4e8f856d4b18b16a23697de0e2322197479a5d0c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
