[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 This doesn't even merge, so tests can't run. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 Can you please run the test again? [SPARK-JIRA-18844.zip](https://github.com/apache/spark/files/1724418/SPARK-JIRA-18844.zip) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 I have committed the changes. Can you please run the test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 As a first time contributor and a novice on it, I would submit the final patch and leave it up to you. You can merge it or leave it. I will close the pull request after that, whether patch is accepted or not. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 Usually I would close them. I often get push-back from those who complain that someone someday might work on it or offer a more compelling take on it. I didn't feel strongly about this, but would not merge it. I erred on the side of leaving it open for any other committer to support it though, but, I don't see that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 Then why was the status of JIRA left open from so many days. It was supposed to be closed earlier. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 As I say, I don't think this would be merged anyway. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 I will generate the patch once again and submit --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20549 **[Test build #4089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4089/testReport)** for PR 20549 at commit [`d7144f6`](https://github.com/apache/spark/commit/d7144f63a99e575d5c996fd7919bdbe44266620f). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20549 **[Test build #4089 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4089/testReport)** for PR 20549 at commit [`d7144f6`](https://github.com/apache/spark/commit/d7144f63a99e575d5c996fd7919bdbe44266620f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 I can run the tests for you, but, not sure this would be merged even if it passes. (You won't have permissions to let the tests run or whitelist yourself) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 Srowen: Will the result of the test not be posted? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20549 I'm not sure there was support to make this change. The value of these additional metrics is pretty marginal. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 ok to test. Jenkins, add to whitelist. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20549 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20549: SPARK-18844[MLLIB] Add more binary classification metric...
Github user sandecho commented on the issue: https://github.com/apache/spark/pull/20549 [SPARK-18844.zip](https://github.com/apache/spark/files/1708136/SPARK-18844.zip) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
