[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sandecho]

Github user sandecho commented on the issue:

https://github.com/apache/spark/pull/20708
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20708
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20708
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sandecho]

Github user sandecho commented on the issue:

https://github.com/apache/spark/pull/20708
  
Thanks @wbstclair . That's a good suggestion. Although I would have to take 
it to ML from MLLIB, rest will be the same.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[wbstclair]

Github user wbstclair commented on the issue:

https://github.com/apache/spark/pull/20708
  
Sorry for being out of touch! I have been busy with work. I will look at
your code soon. I also have an implementation which adheres to the style
which is a decent first draft, but needs to be tested. I think we can build
a decent offering out of the two.

On Mar 1, 2018 9:54 PM, "Sandeep Kumar Choudhary" 
wrote:

> @sethah  Thank you. I accept your
> recommendation. I will take it to ML. Secondly I have written unit tests
> and I have also adhere to style guidelines. But my concern is that no one
> is having a discussion on the JIRA. Even the creator of the JIRA
> @wbstclair  is not reachable.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sandecho]

Github user sandecho commented on the issue:

https://github.com/apache/spark/pull/20708
  
@sethah Thank you. I accept your recommendation. I will take it to ML. 
Secondly I have written unit tests and I have also adhere to style guidelines. 
But my concern is that no one is having a discussion on the JIRA. Even the 
creator of the JIRA @wbstclair is not reachable.



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sethah]

Github user sethah commented on the issue:

https://github.com/apache/spark/pull/20708
  
* Only committers can trigger the tests. 
* MLlib is in maintenance only mode, so we wouldn't accept this patch as 
is. 
* If this were to go into ML, I think you'd need to discuss it more 
thoroughly on the JIRA. Another good alternative is to make this a Spark 
package. 
* It's best if you write unit tests and adhere to the style guides when you 
submit new patches. 

I would recommend closing this PR until more discussion has taken place 
about whether or not this is a good fit for Spark ML. Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sandecho]

Github user sandecho commented on the issue:

https://github.com/apache/spark/pull/20708
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20708
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[sandecho]

Github user sandecho commented on the issue:

https://github.com/apache/spark/pull/20708
  
ok to test


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20708: [SPARK-21209][MLLLIB] Implement Incremental PCA algorith...

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20708
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org