[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20841 Merged to master and branch-2.3. Thank you @ueshin, @BryanCutler and @viirya for reviewing this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20841 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88339/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88339/testReport)** for PR 20841 at commit [`3a8de04`](https://github.com/apache/spark/commit/3a8de043162adc250aa734f747cece1bb161e20e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88339/testReport)** for PR 20841 at commit [`3a8de04`](https://github.com/apache/spark/commit/3a8de043162adc250aa734f747cece1bb161e20e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1581/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20841 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88336/testReport)** for PR 20841 at commit [`3a8de04`](https://github.com/apache/spark/commit/3a8de043162adc250aa734f747cece1bb161e20e). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88336/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88336/testReport)** for PR 20841 at commit [`3a8de04`](https://github.com/apache/spark/commit/3a8de043162adc250aa734f747cece1bb161e20e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1578/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20841
Ah, I got the point. So, you mean a dictionary-like approach -
`get("non-existant-key")` should return `None` always instead of throwing an
error, language-specifically? I think we might consider to allow other
dictionary-like operations together similarly but otherwise it might be fine to
leave it consistent with Scala side.
Strictly, I blieve this PR doesn't change that behaviour if I understood
correctly but just preserves it anyway.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20841 Yeah, true that is how the Scala side works so I suppose that is best, but I kind of view this api similar to the python `dict.get` which returns None and won't raise an error, and that would act --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20841 I think we should better match Python side behaviour to Scala side in general and throw a better exception if possible. I think the application conf was done like that because there wasn't `_NoValue` concept at that time. Both sides were not the same already .. BTW, could I ask to fix it separately please? I actually know several places that we might have to consider `_NoValue` . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20841 Shouldn't it be the same as in the application conf here https://github.com/apache/spark/blob/master/python/pyspark/conf.py#L174? Here the default is `None` and it returns `None` if the conf doesn't contain the and the user doesn't explicitly set a default. There isn't really any value in getting a PY4JError right? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88300/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88300/testReport)** for PR 20841 at commit [`d8ee18f`](https://github.com/apache/spark/commit/d8ee18fab1a6183dfffa6e070e852fda67e1d809). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88300/testReport)** for PR 20841 at commit [`d8ee18f`](https://github.com/apache/spark/commit/d8ee18fab1a6183dfffa6e070e852fda67e1d809). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1555/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20841 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88298/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88298 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88298/testReport)** for PR 20841 at commit [`d8ee18f`](https://github.com/apache/spark/commit/d8ee18fab1a6183dfffa6e070e852fda67e1d809). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88298/testReport)** for PR 20841 at commit [`d8ee18f`](https://github.com/apache/spark/commit/d8ee18fab1a6183dfffa6e070e852fda67e1d809). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1553/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88294/testReport)** for PR 20841 at commit [`1a6cfce`](https://github.com/apache/spark/commit/1a6cfcea2fd23a2a8b7cd0604507a8eb502962a6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88294/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88294/testReport)** for PR 20841 at commit [`1a6cfce`](https://github.com/apache/spark/commit/1a6cfcea2fd23a2a8b7cd0604507a8eb502962a6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1551/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20841 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88291/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88291/testReport)** for PR 20841 at commit [`1a6cfce`](https://github.com/apache/spark/commit/1a6cfcea2fd23a2a8b7cd0604507a8eb502962a6). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20841 **[Test build #88291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88291/testReport)** for PR 20841 at commit [`1a6cfce`](https://github.com/apache/spark/commit/1a6cfcea2fd23a2a8b7cd0604507a8eb502962a6). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1549/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20841 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20841: [SPARK-23706][PYTHON] spark.conf.get(value, default=None...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20841 cc @cloud-fan, @viirya, @ueshin, @BryanCutler who I can directly think of for now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
