[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20879
  
cc @felixcheung and @shaneknapp 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20879
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20879
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1713/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20879
  
**[Test build #88519 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)**
 for PR 20879 at commit 
[`bdd024b`](https://github.com/apache/spark/commit/bdd024b4e73c5d8814df43064a770a06c318cd07).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20879
  
**[Test build #88519 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88519/testReport)**
 for PR 20879 at commit 
[`bdd024b`](https://github.com/apache/spark/commit/bdd024b4e73c5d8814df43064a770a06c318cd07).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20879
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20879
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88519/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread shaneknapp
Github user shaneknapp commented on the issue:

https://github.com/apache/spark/pull/20879
  
i've had to punt on figuring out how to get spark to reliably build across 
branches on the ubuntu workers...  mostly because i haven't been able to 
successfully get the proper versions of various R packages installed that 
mirror what's on the old and barely touched centos workers.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread shaneknapp
Github user shaneknapp commented on the issue:

https://github.com/apache/spark/pull/20879
  
other than that, this PR LGTN++


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/20879
  
thanks! those are on me then. 
are we not running lintr? or these checks are on the newer version only?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20879
  
Yup, we are running old lint in PR builders and those are on the newer one.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20879
  
Merged to master and branch-2.3.

Thanks for reviewing this @shaneknapp and @felixcheung.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org