[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-23 Thread vanzin
Github user vanzin commented on the issue:

https://github.com/apache/spark/pull/20883
  
Merging to master, 2.3, 2.2.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-23 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/20883
  
Thanks, LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-23 Thread felixalbani
Github user felixalbani commented on the issue:

https://github.com/apache/spark/pull/20883
  
@mgaido91 Thanks, I updated description with your suggestions


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-23 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/spark/pull/20883
  
please update the description moving

> Fixes SPARK-23759 by moving connector.start() after connector.setHost()

after the title (What changes...) and please remove the sentence:

> This pull is to fix SPARK-23759 issue

since you are referencing the JIRA in the commit message, thus it is 
obvious that it fixes that JIRA...

Other than this, LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20883: [SPARK-23759][UI] Unable to bind Spark UI to specific ho...

2018-03-22 Thread felixalbani
Github user felixalbani commented on the issue:

https://github.com/apache/spark/pull/20883
  
@gerashegalov Updated the PR title


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org