[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21145 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21145 Thanks @jose-torres! I appreciate not blocking this commit on those changes, since it would be difficult to keep this up to date from the other paths changing, while we discussed what to call these classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/21145 LGTM. I can own cleaning up the names of the streaming classes, probably wrapping that into the broader task of getting a design doc for the streaming reader API. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21145 LGTM to `InputPartition`. CC @marmbrus @jose-torres to check the streaming side. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21145 Overall, +1 for the change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21145 `InputPartition` is good and straightforward ð --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21145 any other suggestions about naming? we are going to rename `DataReaderFactory` to `InputPartition`. cc @rxin @marmbrus @jose-torres --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90382/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90382/testReport)** for PR 21145 at commit [`1423979`](https://github.com/apache/spark/commit/1423979edd24aa869b945bc3911630176c83eee5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3050/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90382/testReport)** for PR 21145 at commit [`1423979`](https://github.com/apache/spark/commit/1423979edd24aa869b945bc3911630176c83eee5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3049/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90381 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90381/testReport)** for PR 21145 at commit [`ec53d12`](https://github.com/apache/spark/commit/ec53d127c37f1a0540fd4fe0505674367e7ad7ca). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90381/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90381 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90381/testReport)** for PR 21145 at commit [`ec53d12`](https://github.com/apache/spark/commit/ec53d127c37f1a0540fd4fe0505674367e7ad7ca). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90380/testReport)** for PR 21145 at commit [`3eff34b`](https://github.com/apache/spark/commit/3eff34b58b54fb7469c7a3f100c6d9cd86e7daa1). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90380/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21145 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21145 **[Test build #90380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90380/testReport)** for PR 21145 at commit [`3eff34b`](https://github.com/apache/spark/commit/3eff34b58b54fb7469c7a3f100c6d9cd86e7daa1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to InputPar...
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21145 @cloud-fan, I've updated this PR to use `InputPartition` and similar names, since we seem to have consensus around it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
